From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrBfn-0003Mk-AS for qemu-devel@nongnu.org; Tue, 17 Jul 2012 13:35:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrBfl-0007XG-NO for qemu-devel@nongnu.org; Tue, 17 Jul 2012 13:34:59 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:62632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrBfl-0007X4-GY for qemu-devel@nongnu.org; Tue, 17 Jul 2012 13:34:57 -0400 Received: by bkcji1 with SMTP id ji1so588419bkc.4 for ; Tue, 17 Jul 2012 10:34:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <50059AF3.2050603@siemens.com> References: <1342543307-10964-1-git-send-email-peter.maydell@linaro.org> <50059AF3.2050603@siemens.com> Date: Tue, 17 Jul 2012 18:34:56 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" , "patches@linaro.org" On 17 July 2012 18:03, Jan Kiszka wrote: > On 2012-07-17 18:41, Peter Maydell wrote: >> Rather than hardcoding the list of architectures in the kernel >> header update script, just import headers for every architecture >> which supports KVM. This reduces the number of QEMU files which >> need to be updated to add support for a new KVM architecture. >> It also means we won't break if the kernel drops support for >> an architecture in the future. >> >> Signed-off-by: Peter Maydell >> --- >> I'd like this for ARM, obviously. NB that this change will mean we'll >> pick up the ia64 kvm headers next time somebody does a kernel header >> update; this seems harmless (and perhaps even useful?). ia64 'make >> headers_install' is a bit noisy as of 3.5-rc5 but succeeds anyway. > > IA64 KVM support is dead and may be removed at some point from the > kernel. What about blacklisting it here already to avoid that noise? It's only noisy for the developer who runs the script, and if we blacklist it then we'll have to update the script again to remove it from the blacklist when it finally dies. I don't feel very strongly about it, though, so I can add an # Blacklist architectures which have KVM headers but are actually dead if [ "$arch" = "ia64" ]; then continue fi to the patch if you want. -- PMM