All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: gaosong <gaosong@loongson.cn>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,  alex.bennee@linaro.org,
	maobibo@loongson.cn
Subject: Re: [RISU PATCH 1/5] risu: Use alternate stack
Date: Tue, 11 Oct 2022 10:27:02 +0100	[thread overview]
Message-ID: <CAFEAcA839Om2gmweTcNqo3HPAQAoJ4xgA36ZLPE3V2KctX4qkA@mail.gmail.com> (raw)
In-Reply-To: <34b95105-711e-7dab-d5cb-fad315e8c26b@loongson.cn>

On Tue, 11 Oct 2022 at 07:57, gaosong <gaosong@loongson.cn> wrote:
>
>
> 在 2022/10/10 22:43, Peter Maydell 写道:
> > On Mon, 10 Oct 2022 at 15:20, Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >> On 9/17/22 00:43, Song Gao wrote:
> >>> We can use alternate stack, so that we can use sp register as intput/ouput register.
> >>> I had tested aarch64/LoongArch architecture.
> >>>
> >>> Signed-off-by: Song Gao<gaosong@loongson.cn>
> >>> ---
> >>>    risu.c | 16 +++++++++++++++-
> >>>    1 file changed, 15 insertions(+), 1 deletion(-)
> >> Good idea.
> > Depending on the architecture there might still need to be
> > restrictions on use of the stack pointer, eg aarch64's
> > alignment requirements, but this at least means you can
> > in theory write some risu rules that use SP.
> I really want use alternate stack, this way can reduce risu rules.
> what about use this only on LoongArch architecture ?

I just mean that although this patch is fine it might
still mean that depending on the architecture some care
and/or special casing of sp in the target risu rules
might be needed. I don't know if that applies to
loongarch or not.

-- PMM


  reply	other threads:[~2022-10-11  9:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17  7:43 [RISU PATCH 0/5] Add LoongArch architectures support Song Gao
2022-09-17  7:43 ` [RISU PATCH 1/5] risu: Use alternate stack Song Gao
2022-10-10 14:20   ` Richard Henderson
2022-10-10 14:43     ` Peter Maydell
2022-10-11  6:56       ` gaosong
2022-10-11  9:27         ` Peter Maydell [this message]
2022-09-17  7:43 ` [RISU PATCH 2/5] loongarch: Add LoongArch basic test support Song Gao
2022-10-10 14:58   ` Richard Henderson
2022-10-10 15:34   ` Peter Maydell
2022-10-11  1:48     ` gaosong
2022-09-17  7:43 ` [RISU PATCH 3/5] loongarch: Implement risugen module Song Gao
2022-10-10 15:19   ` Richard Henderson
2022-09-17  7:43 ` [RISU PATCH 4/5] loongarch: Add risufile with loongarch instructions Song Gao
2022-10-10 15:21   ` Richard Henderson
2022-09-17  7:43 ` [RISU PATCH 5/5] loongarch: Add block 'safefloat' and nanbox_s() Song Gao
2022-10-10 15:24   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA839Om2gmweTcNqo3HPAQAoJ4xgA36ZLPE3V2KctX4qkA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.