From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35163)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UfsD1-0005Qf-IQ
	for qemu-devel@nongnu.org; Fri, 24 May 2013 09:39:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UfsCw-0002Rm-Cp
	for qemu-devel@nongnu.org; Fri, 24 May 2013 09:39:03 -0400
Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:56994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UfsCw-0002RQ-5r
	for qemu-devel@nongnu.org; Fri, 24 May 2013 09:38:58 -0400
Received: by mail-la0-f53.google.com with SMTP id ea20so4396279lab.26
	for <qemu-devel@nongnu.org>; Fri, 24 May 2013 06:38:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <519F6C28.9050302@redhat.com>
References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com>
	<1369133851-1894-16-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-LTgN_W_2kSKUoBPtgyuEV0h=GDABAh+gqo6FHHQTshw@mail.gmail.com>
	<519F1E7E.7050700@redhat.com>
	<CAFEAcA_0dAud4Fh3p5GMHo1kKjDcrHwvKruHdA+ed9vE2AGbNQ@mail.gmail.com>
	<519F63EE.8080208@redhat.com>
	<CAFEAcA9SJ4Z7_5yM_GOzMqszCTsGbD2eTLk-n1X42QmQCYSVgQ@mail.gmail.com>
	<519F6C28.9050302@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 24 May 2013 14:38:36 +0100
Message-ID: <CAFEAcA83K+vsfz9eCj1gN8-x3uBq5v1YjRdG0yjFibmY_GfpNg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, qemu-devel@nongnu.org, jan.kiszka@gmail.com

On 24 May 2013 14:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 24/05/2013 15:27, Peter Maydell ha scritto:
>> On 24 May 2013 13:58, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> If it's okay
>>> for you, I'll send a pull request up to "memory: clean up phys_page_find"
>>> and go on with the next series.
>>
>> That's fine with me, but please don't forget to fix up
>> the doc comment for memory_region_find() (see comments on
>> patch 6/30). You can do that in a patch in the next series,
>> though, I guess.
>
> What about this:
>
> /**
>  * memory_region_find: translate an address/size relative to a
>  * MemoryRegion into a #MemoryRegionSection.
>  *
>  * Locates the first #MemoryRegion within @mr that overlaps the range
>  * given by @addr and @size.
>  *
>  * Returns a #MemoryRegionSection that describes a contiguous overlap.
>  * It will have the following characteristics:
>  *    .@size = 0 iff no overlap was found
>  *    .@mr is non-%NULL iff an overlap was found
>  *
>  * Remember that in the return value the @offset_within_region is
>  * relative to the returned region (in the .@mr field), not to the
>  * @mr argument.
>  *
>  * Similarly, the .@offset_within_address_space is relative to the
>  * address space that contains both regions, the passed and the
>  * returned one.  However, in the special case where the @mr argument
>  * has no parent (and thus is the root of the address space), the
>  * following will hold:
>  *    .@offset_within_address_space >= @addr
>  *    .@offset_within_address_space + .@size <= @addr + @size
>  *
>  * @mr: a MemoryRegion within which @addr is a relative address
>  * @addr: start of the area within @as to be searched
>  * @size: size of the area to be searched
>  */

Yes, that looks OK to me.

thanks
-- PMM