From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VT9GW-0004yL-PA
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 07:46:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VT9GS-0000TY-9D
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 07:46:20 -0400
Received: from mail-lb0-f180.google.com ([209.85.217.180]:58383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VT9GS-0000T6-25
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 07:46:16 -0400
Received: by mail-lb0-f180.google.com with SMTP id q8so5465882lbi.11
	for <qemu-devel@nongnu.org>; Mon, 07 Oct 2013 04:46:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <525288C9.3080207@adacore.com>
References: <1380905823-3981-1-git-send-email-chouteau@adacore.com>
	<1380905823-3981-4-git-send-email-chouteau@adacore.com>
	<CAFEAcA_WwFU8YsPiYm4j68Ue9JBvLoJ_M-MunbfRxjuppB7H_A@mail.gmail.com>
	<525288C9.3080207@adacore.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 7 Oct 2013 20:45:54 +0900
Message-ID: <CAFEAcA83XgLiSDci7BSnRYc=r8uodHLWsCge-B9-VDWXhqNiXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>

On 7 October 2013 19:11, Fabien Chouteau <chouteau@adacore.com> wrote:
> On 10/04/2013 07:49 PM, Peter Maydell wrote:
>> On 5 October 2013 01:57, Fabien Chouteau <chouteau@adacore.com> wrote:
>> >> @@ -47,7 +48,9 @@
>>>  #include "hw/xen/xen.h"
>>>  #include "hw/i386/apic_internal.h"
>>>  #endif
>>> +#include "monitor/monitor_def.h"
>>>
>>> +extern const MonitorDef i386_monitor_defs[];
>>
>> Declare this in cpu-qom.h, rather than having an
>> extern declaration in a .c file.
>>
>
> I didn't manage to do that.

If you just say "I couldn't make that work" with no details,
there isn't much I can say beyond "try harder" :-)
If you say *why* you couldn't get it to work then I'm more
likely to either (a) suggest an approach that will work or
(b) accept that it really does have to be that way...

thanks
-- PMM