From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B75C4338F for ; Fri, 20 Aug 2021 16:56:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 994946103A for ; Fri, 20 Aug 2021 16:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 994946103A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH7ot-0002Tw-Sa for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 12:56:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH7oA-0001nS-Em for qemu-devel@nongnu.org; Fri, 20 Aug 2021 12:55:54 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:45913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH7o8-0005Lb-QR for qemu-devel@nongnu.org; Fri, 20 Aug 2021 12:55:54 -0400 Received: by mail-ej1-x635.google.com with SMTP id e21so5578729ejz.12 for ; Fri, 20 Aug 2021 09:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DUwsMZZLFjuEK3M3s+PW35GgTPw8hLvChCCR7Wp53UA=; b=oWwJVSDHSVpjx7mSHZl2Zkfxv37dPiPvk7JzXXfwchGscucclN+T/d/F0H7vysFHPu T30BD+WjuksJMgnX0Q8eoqJU0ZIVnyffjKwkpUDsR9NFU/tfaWMX3Sqd0MeZyEL6oP2Z tGw1NrPMZKowLXkvUiZloPPh1fe3a9d3FybSwTL6YcJfAmLv02YeLgV+47dZEkqQokSe ey45ZNekdpUZe59QZ2Pa+5rm079ohI5MfQyHJ8x67Hu6xV+EEPaJoP9bC+WQug8YviTm z437JbRJX3ewgAQJhQVkaYNDjdrfbFyrqMHq+9RqkMC8b57OD0QGsOoOflfDWSNYjOnn 2KwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DUwsMZZLFjuEK3M3s+PW35GgTPw8hLvChCCR7Wp53UA=; b=Y/923FHOSC1TKbNZm4K9Ese5gm3D16928OikNLQ1o1DHpwBn/ZHDTOSeFAvxE070qb UZHX5wS/a9QI64D9RSdH+H2QPPgyRlX7Jnnbfks7HYwTBAnqYGfv3STc2s72NdKbKEnt 9wb4jrLxKYp0ZU/YH7m/7YxGkJf+g/NjlVzp0176vboBeRdQfVNOfsihojQxbetqZAJ2 1INxG7W/rOTjzLKDrn8aGaINyhOlWWzn5p4l5Mli1CL35qL38Zk/aBr36izps3B/xI9y kpshVaFWuiG2fujcb6bGaNO1aaKhN++TtpbXxXzydSBxjYY9YvxSyledcgzRVfjr+np5 uwIg== X-Gm-Message-State: AOAM530XMBoICWeFQyBV2T9kJAPF6zkuyjB15WxrNw/2tPE4HGD12Ymm HIKniNtlmOf8sdhrzH2UwH0UDwVWgrHvtM7sLz6HTg== X-Google-Smtp-Source: ABdhPJz+QGBIcZLZMRMODqU5FWyB1M57AXrqXomVliMuVLNSmgEGA/JIEDb2UAsyM7CwGNTJt8bOY9BL7i+l2EvJZyw= X-Received: by 2002:a17:906:aac7:: with SMTP id kt7mr22661100ejb.4.1629478550548; Fri, 20 Aug 2021 09:55:50 -0700 (PDT) MIME-Version: 1.0 References: <20210511081350.419428-1-pbonzini@redhat.com> <20210511081350.419428-4-pbonzini@redhat.com> In-Reply-To: <20210511081350.419428-4-pbonzini@redhat.com> From: Peter Maydell Date: Fri, 20 Aug 2021 17:55:04 +0100 Message-ID: Subject: Re: [PULL 03/33] i386: split cpu accelerators from cpu.c, using AccelCPUClass To: Paolo Bonzini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , Richard Henderson , QEMU Developers , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 11 May 2021 at 09:22, Paolo Bonzini wrote: > > From: Claudio Fontana > > i386 is the first user of AccelCPUClass, allowing to split > cpu.c into: > > cpu.c cpuid and common x86 cpu functionality > host-cpu.c host x86 cpu functions and "host" cpu type > kvm/kvm-cpu.c KVM x86 AccelCPUClass > hvf/hvf-cpu.c HVF x86 AccelCPUClass > tcg/tcg-cpu.c TCG x86 AccelCPUClass > > Signed-off-by: Claudio Fontana > Reviewed-by: Alex Benn=C3=A9e > Reviewed-by: Richard Henderson > > [claudio]: > Rebased on commit b8184135 ("target/i386: allow modifying TCG phys-addr-b= its") > > Signed-off-by: Claudio Fontana > Message-Id: <20210322132800.7470-5-cfontana@suse.de> > Signed-off-by: Paolo Bonzini > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index b692c8fbee..c2723b32cb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -351,7 +351,7 @@ M: Paolo Bonzini > M: Richard Henderson > M: Eduardo Habkost > S: Maintained > -F: target/i386/ > +F: target/i386/tcg/ > F: tests/tcg/i386/ > F: tests/tcg/x86_64/ > F: hw/i386/ This change to MAINTAINERS has left all the .c files in target/i386 that are not in one of the tcg, hvf, whpx, kvm, hax, nvmm subdirectories orphaned -- they are no longer covered by any MAINTAINERS section. Where should those files be listed ? (I just discovered this when get_maintainers.pl said it couldn't find a maintainer for a change I made to target/i386/sev.c.) thanks -- PMM