From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YF6Qz-00016P-JY
	for qemu-devel@nongnu.org; Sat, 24 Jan 2015 14:31:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YF6Qv-0006dH-KJ
	for qemu-devel@nongnu.org; Sat, 24 Jan 2015 14:31:53 -0500
Received: from mail-lb0-f182.google.com ([209.85.217.182]:43036)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YF6Qv-0006d1-EA
	for qemu-devel@nongnu.org; Sat, 24 Jan 2015 14:31:49 -0500
Received: by mail-lb0-f182.google.com with SMTP id l4so2442466lbv.13
	for <qemu-devel@nongnu.org>; Sat, 24 Jan 2015 11:31:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAOgzsHUaZqjqvpe1+yCtahPKDuopu_07HY0Mca_LyZp+3UwCbA@mail.gmail.com>
References: <1422037228-5363-1-git-send-email-peter.maydell@linaro.org>
	<1422037228-5363-5-git-send-email-peter.maydell@linaro.org>
	<CAOgzsHU=z6BvevFv90d6Za3cb1MPhEiu99gu5wwnCWthBTeF7A@mail.gmail.com>
	<CAFEAcA8ByD9SNkQ4hdjkGz+LHbY8OSapJd1tqHYaDi0L1_Mv7Q@mail.gmail.com>
	<CAOgzsHUaZqjqvpe1+yCtahPKDuopu_07HY0Mca_LyZp+3UwCbA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 24 Jan 2015 19:31:27 +0000
Message-ID: <CAFEAcA86q-b6g7r2Vb=p6S8MnW1qTXD2GbL9TKi0JjuY8zUAig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx
 values and pass them in TB flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Andrew Jones <drjones@redhat.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 24 January 2015 at 16:36, Greg Bellows <greg.bellows@linaro.org> wrote:
> I understand what the code is doing, my point is that you rely on
> arm_is_secure_below_el3 to deal with EL2 when you could have just as easily
> checked for el<2.  Not a big deal though.

Well, I rely on the architecture to tell me that it isn't
possible for arm_is_secure_below_el3 to be true if we're
in EL2. Otherwise there'd be a bug in that function...

-- PMM