From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsL79-0005kF-UO for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:56:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsL79-0007cB-78 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:56:31 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:63764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsL78-0007by-VH for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:56:31 -0400 Received: by mail-lb0-f181.google.com with SMTP id w10so700721lbi.12 for ; Thu, 27 Jun 2013 15:56:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1372373098-5877-3-git-send-email-mrhines@linux.vnet.ibm.com> References: <1372373098-5877-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372373098-5877-3-git-send-email-mrhines@linux.vnet.ibm.com> From: Peter Maydell Date: Thu, 27 Jun 2013 23:56:09 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 27 June 2013 23:44, wrote: > arch_init.c | 29 +++++++++++++++++++---------- > include/migration/migration.h | 2 ++ Implementation in arch_init.c but prototype in migration.h? The function pretty clearly has nothing to do with initialization anyway, which suggests it's just in the wrong place (along with a pile of other migration related code there). thanks -- PMM