From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1gtEWo-0003DI-SL
	for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:33:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1gtEWm-0003vI-BU
	for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:33:53 -0500
Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:45715)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)
	id 1gtEWk-0003qs-7O
	for qemu-devel@nongnu.org; Mon, 11 Feb 2019 11:33:52 -0500
Received: by mail-ot1-x333.google.com with SMTP id 32so18416955ota.12
	for <qemu-devel@nongnu.org>; Mon, 11 Feb 2019 08:33:38 -0800 (PST)
MIME-Version: 1.0
References: <1549390526-24246-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA8-Hst3Buax1Qrrm1SVbTtkE-8a_Vj0y3N4TvfPTqR_zw@mail.gmail.com>
	<CAFEAcA9Yh=fCuBT602deTt0OJQux9ZMGXvGX3Bx_iXNiTskNSA@mail.gmail.com>
	<3b62bab9-db61-f40e-da52-561a0cd9ee25@redhat.com>
In-Reply-To: <3b62bab9-db61-f40e-da52-561a0cd9ee25@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 11 Feb 2019 16:33:26 +0000
Message-ID: <CAFEAcA8=cKCUSshf8URKJWiBj26NEiBb5zEbsGz-faM-41R1Qg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [Qemu-devel] [PULL v2 00/76] misc patches for 2019-02-04
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Hildenbrand <david@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, 11 Feb 2019 at 16:29, David Hildenbrand <david@redhat.com> wrote:
>
> On 05.02.19 21:05, Peter Maydell wrote:
> > This part looks like the usual "foo-softmmu/config-devices.mak isn't updated
> > if a file that's #included from default-configs/foo-softmmu.mak is
> > changed" dependency bug -- I guess the fix for that isn't in this
> > patchset ?  The mips stuff is probably the same.
> >
> > I'll delete the config-devices.mak files by hand, which should
> > suffice to get the build to go through.
> >
>
> ../hw/acpi/piix4.o: In function `piix4_pm_realize':
> /home/dhildenb/git/qemu/hw/acpi/piix4.c:515: undefined reference to
> `pm_smbus_init'
> ../hw/i2c/smbus_ich9.o: In function `ich9_smbus_realize':
> /home/dhildenb/git/qemu/hw/i2c/smbus_ich9.c:89: undefined reference to
> `pm_smbus_init'
> ../hw/pci-host/piix.o: In function `i440fx_update_memory_mappings':
> /home/dhildenb/git/qemu/hw/pci-host/piix.c:149: undefined reference to
> `pam_update'
> ../hw/pci-host/piix.o: In function `i440fx_init':
> /home/dhildenb/git/qemu/hw/pci-host/piix.c:416: undefined reference to
> `init_pam'
> /home/dhildenb/git/qemu/hw/pci-host/piix.c:419: undefined reference to
> `init_pam'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:207: qemu-system-x86_64] Error 1
> make: *** [Makefile:432: subdir-x86_64-softmmu] Error 2
>
>
> Even after make clean + configure. Which step am I missing?

The "delete the config-devices.mak files by hand" step, I expect.
(This is working around a very long standing bug in our makefiles
which will be removed in passing by the KConfig work.)

thanks
-- PMM