From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1fH6rJ-0002ho-Nh
	for qemu-devel@nongnu.org; Fri, 11 May 2018 08:09:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1fH6rJ-0003Hf-0e
	for qemu-devel@nongnu.org; Fri, 11 May 2018 08:09:13 -0400
Received: from mail-ot0-x243.google.com ([2607:f8b0:4003:c0f::243]:45018)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)
	id 1fH6rI-0003HL-SL
	for qemu-devel@nongnu.org; Fri, 11 May 2018 08:09:12 -0400
Received: by mail-ot0-x243.google.com with SMTP id g7-v6so5951660otj.11
	for <qemu-devel@nongnu.org>; Fri, 11 May 2018 05:09:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20180510222601.19944-2-laurent@vivier.eu>
References: <20180510222601.19944-1-laurent@vivier.eu>
	<20180510222601.19944-2-laurent@vivier.eu>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 11 May 2018 13:08:52 +0100
Message-ID: <CAFEAcA8A0k6zRSO2mmxZ7cU139zZ3upD5rqm4rGLtYWpKMd15g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [Qemu-devel] [PATCH 1/5] linux-user: move mips socket.h
 definitions to mips/sockbits.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Riku Voipio <riku.voipio@iki.fi>, Yongbok Kim <yongbok.kim@mips.com>, Richard Henderson <rth@twiddle.net>

On 10 May 2018 at 23:25, Laurent Vivier <laurent@vivier.eu> wrote:
> No code change.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> +#if 0
> +/* To add: Allow local address and port reuse. */
> +#define TARGET_SO_REUSEPORT 0x0200
> +#endif

As a follow-on cleanup, we might as well fix up the various
targets to actually define TARGET_SO_REUSEPORT rather than
defining it by #if'ing out the definition or commenting it out
or not defining it at all.

thanks
-- PMM