All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked
Date: Tue, 20 Apr 2021 12:50:56 +0100	[thread overview]
Message-ID: <CAFEAcA8ARLDBXPL1kDYN8QXw_dC5t9vHEb=T06d2gX7tSkKFJA@mail.gmail.com> (raw)
In-Reply-To: <YH6d+LUPKqstoLHP@work-vm>

On Tue, 20 Apr 2021 at 10:25, Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote:
> > > Result @blocked is true when and only when result @blocked-reasons is
> > > present.  It's always non-empty when present.  @blocked is redundant.
> > > It was introduced in commit 3af8554bd0 "migration: Add blocker
> > > information", and has not been released.  This gives us a chance to
> > > fix the interface with minimal fuss.
> > >
> > > Unfortunately, we're already too close to the release to risk dropping
> > > it.  Deprecate it instead.
> > >
> > > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > > ---
> > > This is alternative to "[PATCH v2] migration: Drop redundant
> > > query-migrate result @blocked".
> > >
> > >  qapi/migration.json | 9 +++++++--
> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Yes,
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Peter: Do you want to pick that up directly ?

Yep; applied to master for 6.0.

thanks
-- PMM


      reply	other threads:[~2021-04-20 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  5:19 [PATCH] migration: Deprecate redundant query-migrate result @blocked Markus Armbruster
2021-04-20  8:29 ` Daniel P. Berrangé
2021-04-20  9:25   ` Dr. David Alan Gilbert
2021-04-20 11:50     ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8ARLDBXPL1kDYN8QXw_dC5t9vHEb=T06d2gX7tSkKFJA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.