From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRgRU-0000jN-1J for qemu-devel@nongnu.org; Wed, 20 Dec 2017 10:39:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRgQT-0004Kb-Nc for qemu-devel@nongnu.org; Wed, 20 Dec 2017 10:37:59 -0500 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]:36389) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRgQT-0004Jk-8x for qemu-devel@nongnu.org; Wed, 20 Dec 2017 10:36:57 -0500 Received: by mail-ot0-x241.google.com with SMTP id d5so19955761oti.3 for ; Wed, 20 Dec 2017 07:36:57 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20171219201613.7399-1-michael.weiser@gmx.de> <20171219201613.7399-3-michael.weiser@gmx.de> From: Peter Maydell Date: Wed, 20 Dec 2017 15:36:29 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/5] linux-user: Add separate aarch64_be uname List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Michael Weiser , QEMU Developers , Riku Voipio On 20 December 2017 at 15:20, Laurent Vivier wrote: > Le 19/12/2017 =C3=A0 21:16, Michael Weiser a =C3=A9crit : >> Make big-endian aarch64 systems identify as aarch64_be as expected by >> big-endian userland and toolchains. >> >> Signed-off-by: Michael Weiser >> --- >> linux-user/aarch64/target_syscall.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/ta= rget_syscall.h >> index 1b62953eeb..604ab99b14 100644 >> --- a/linux-user/aarch64/target_syscall.h >> +++ b/linux-user/aarch64/target_syscall.h >> @@ -8,7 +8,11 @@ struct target_pt_regs { >> uint64_t pstate; >> }; >> >> +#if defined(TARGET_WORDS_BIGENDIAN) >> +#define UNAME_MACHINE "aarch64_be" >> +#else >> #define UNAME_MACHINE "aarch64" >> +#endif >> #define UNAME_MINIMUM_RELEASE "3.8.0" > > For aarch64_be, I think the minimum release should be 4.9.0 > (see kernel commit cfa88c79462d "arm64: Set UTS_MACHINE in the Makefile") Isn't the thing that defines what we set the minimum-release to glibc, not the kernel? That is, the reason we lie to the guest about the kernel version for some architectures is because the glibc for those archs insists on a minimum kernel version which the host may not have. Unless aarch64_be glibc insists on kernel 4.9.0 there's no need to tell the guest that. thanks -- PMM