From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFA2C3E8C5 for ; Fri, 27 Nov 2020 18:19:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FEF6208B3 for ; Fri, 27 Nov 2020 18:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GPCTRzXS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FEF6208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiiKi-0001El-BH for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 13:19:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiiIT-0007r2-Ub for qemu-devel@nongnu.org; Fri, 27 Nov 2020 13:16:42 -0500 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:44718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiiIS-0002sg-Et for qemu-devel@nongnu.org; Fri, 27 Nov 2020 13:16:41 -0500 Received: by mail-ed1-x542.google.com with SMTP id l5so6562818edq.11 for ; Fri, 27 Nov 2020 10:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TtNyEniRpB/eU0S5XP7+Qk/KQ/pfCRKdD+Wh0ljo51Q=; b=GPCTRzXSKBcvOlHwtl9IqLGJp9lhZmbFDIrVnWFgWz1CnOA9ecJ72szqwVBRDcrZ/M /JviOMLnbK8yJwu2TYrXKiutZ3kShEnoxxQtmdNTnRms0fNXRU0/FVXaR9oi33P1sPsD 1VLzIioK33t5zcBj/1Z+tSkAg0dyoMLF/qNNhiwxXk1560eV/J0CqSqHWxSsBPTwKCdP lj+dLWReuAg67BnOih6Y0Hp/opsHmqjwKNwLPCp8gYFxMaaG97b6dDHLBc7PjZpJzenA LhC5UkQxhxE8SMrNzclll/jQBQfeLJYSrtGfCXYf/VtSqPeW0VEO5/ASJiGFsrePF5c2 nw0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TtNyEniRpB/eU0S5XP7+Qk/KQ/pfCRKdD+Wh0ljo51Q=; b=Zp/NvSpgBGW4nArsD1/2Zwtxc7AKPVlGl84hZK9kTJyRKZ5RTUrmFAd4csnc2HpjXb i1mdtXN5t6a/7qc0JvZYGAtW3spGwWwgYjE7ntGLaToEhb6rTKj2TVuzRcQU+x5PJDLv h0iGvCCeo2c+2Ai0e/Ts6O4THJZ+wTlzzF0cZPoSZDHP9CqvAZegABNXCdSTfrLy/6qu 95sTRgYxX/84dkiBpHUacZPrstyW/DRKqoUKmiAxfF9R6WxoJ20KDkFToKQbQEe5tiV5 zzR45EU/8UdDWV/y9KtABRoiTWNHvWStd1Neo7UV/nZouzcTyUDiRTIWbFXSYtRl+yTu OcgQ== X-Gm-Message-State: AOAM531dOMoRjjUxlUmbETC1Zf61cCa9I3fEGnsdg+mTtjH6oOJEAdiY KuTR5kLbQ76zUmbqihN35gMLJ7nwDqDEsihwMhs9Yw== X-Google-Smtp-Source: ABdhPJzGQwZ8ODyXj+AXxWmJ9KHCVlESDX3WWxb71+l4hGOC4a7ffKTqE/rOJkZtfXOjZYq7uNCVfrVmTzBvkdd8hKc= X-Received: by 2002:a05:6402:30b5:: with SMTP id df21mr9307062edb.146.1606500998637; Fri, 27 Nov 2020 10:16:38 -0800 (PST) MIME-Version: 1.0 References: <20201126215017.41156-1-agraf@csgraf.de> <20201126215017.41156-9-agraf@csgraf.de> <20201126221405.GT2271382@habkost.net> <20201127162633.GY2271382@habkost.net> <20201127164708.GZ2271382@habkost.net> <20201127171757.GB2271382@habkost.net> In-Reply-To: <20201127171757.GB2271382@habkost.net> From: Peter Maydell Date: Fri, 27 Nov 2020 18:16:27 +0000 Message-ID: Subject: Re: [PATCH 8/8] hw/arm/virt: Disable highmem when on hypervisor.framework To: Eduardo Habkost Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x542.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , QEMU Developers , Cameron Esfahani , Roman Bolshakov , Alexander Graf , Claudio Fontana , qemu-arm , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 27 Nov 2020 at 17:18, Eduardo Habkost wrote: > Thanks! Is the data returned by kvm_arm_get_host_cpu_features() > supposed to eventually affect the value of id_aa64mmfr0? I don't > see how that could happen. kvm_arm_get_host_cpu_features() does: err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64mmfr0, ARM64_SYS_REG(3, 0, 0, 7, 0)); which is filling in data in the ARMHostCPUFeatures* that it is passed as an argument. The caller is kvm_arm_set_cpu_features_from_host(), which does kvm_arm_get_host_cpu_features(&arm_host_cpu_features) (assuming it hasn't already done it once and cached the results; arm_host_cpu_features is a global) and then cpu->isar = arm_host_cpu_features.isar; thus copying the ID values into the "struct ARMISARegisters isar" that is part of the ARMCPU struct. (It also copies across the 'features' word which gets set up with ARM_FEATURE_* flags for the benefit of the parts of the target code which key off those rather than ID register fields.) thanks -- PMM