From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDWRg-0007er-6S for qemu-devel@nongnu.org; Fri, 10 Jul 2015 07:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDWRb-0001nN-Ua for qemu-devel@nongnu.org; Fri, 10 Jul 2015 07:26:20 -0400 Received: from mail-vn0-f53.google.com ([209.85.216.53]:43780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDWRb-0001nH-QE for qemu-devel@nongnu.org; Fri, 10 Jul 2015 07:26:15 -0400 Received: by vnbf1 with SMTP id f1so26481082vnb.10 for ; Fri, 10 Jul 2015 04:26:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1434419515-3572-1-git-send-email-edgar.iglesias@gmail.com> <1434419515-3572-5-git-send-email-edgar.iglesias@gmail.com> From: Peter Maydell Date: Fri, 10 Jul 2015 12:25:56 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v5 4/6] target-arm: Add the Hypervisor timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: Sergey Fedorov , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Alexander Graf , QEMU Developers On 10 July 2015 at 12:23, Edgar E. Iglesias wrote: > > On 10/07/2015 7:58 pm, "Peter Maydell" wrote: >> Something I just noticed while I was trying to add support >> for the secure physical timer on top of this series: the >> gt_*_cnt_reset functions are misnamed, because they're not >> resetting the counters, they're resetting the timers. >> (There are only two counters, physical and virtual, but there >> are four timers, physical, secure-physical, virtual and hyp. >> Since our reset function is deleting the underlying QEMU >> timer it's a timer reset, not a counter reset.) >> We should probably fix up the names and make sure they're >> associated with the correct registers (the phys and virt >> timer reset is currently hanging off a counter register) > Hi, yes that sounds good. Btw are you fixing this as you go or should I send > a new series fixing your comments? I've fixed the stuff you commented on a > few days ago in my tree... I rebased as I was reviewing it and am currently basing my secure-timer patches on that. It would probably be good if you fixed up the naming issue here and resent, and then I'll rebase on top of that. -- PMM