From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRQ2O-0002tB-Mg
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:21:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRQ2I-0000a5-7X
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:21:08 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:40631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XRQ2H-0000Zy-Va
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 14:21:02 -0400
Received: by mail-lb0-f173.google.com with SMTP id w7so4464643lbi.18
	for <qemu-devel@nongnu.org>; Tue, 09 Sep 2014 11:21:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1409930126-28449-2-git-send-email-ard.biesheuvel@linaro.org>
References: <1409930126-28449-1-git-send-email-ard.biesheuvel@linaro.org>
	<1409930126-28449-2-git-send-email-ard.biesheuvel@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 9 Sep 2014 19:20:40 +0100
Message-ID: <CAFEAcA8FxV1-miGLumDjiecFrkxBj2tQVm3XFp4jmkMDKt9wJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Provide flash devices for
	boot ROMs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Fu Wei <fu.wei@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>

On 5 September 2014 16:15, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> From: Peter Maydell <peter.maydell@linaro.org>
>
> Add two flash devices to the virt board, so that it can be used for
> running guests which want a bootrom image such as UEFI. We provide
> two flash devices to make it more convenient to provide both a
> read-only UEFI image and a read-write place to store guest-set
> UEFI config variables. The '-bios' command line option is set up
> to provide an image for the first of the two flash devices.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/arm/virt.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)

This one's been around long enough that I'm going to add
it to target-arm.next now.

There were previously questions about whether we should
have flash or RAM at the bottom, but I think it makes
sense just to have a "like vexpress" config with two
flash devices. This does make telling QEMU about backing
storage for the 2nd flash a little complicated, but I
think anybody seriously running a config like that will
be using the management tools layer anyhow.

thanks
-- PMM