From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ygV-0005i2-LL for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:42:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6ygU-0002Us-TO for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:42:51 -0500 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:35413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ygU-0002UT-Pb for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:42:50 -0500 Received: by vkha189 with SMTP id a189so77079182vkh.2 for ; Thu, 10 Dec 2015 02:42:50 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1449743372-17169-3-git-send-email-armbru@redhat.com> References: <1449743372-17169-1-git-send-email-armbru@redhat.com> <1449743372-17169-3-git-send-email-armbru@redhat.com> From: Peter Maydell Date: Thu, 10 Dec 2015 10:42:31 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: QEMU Developers On 10 December 2015 at 10:29, Markus Armbruster wrote: > Device init() methods aren't supposed to call hw_error(), they should > report the error and fail cleanly. Do that. > > Cc: Peter Maydell > Signed-off-by: Markus Armbruster These are all really "QEMU bug" error paths -- the only place that uses omap_i2c is the omap SoC init, you can't create the device on the command line, and so we'll only get these errors if there's a bug in a function like omap2420_mpu_init. But I don't object to the patch in principle. Reviewed-by: Peter Maydell thanks -- PMM