From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YfSIP-0001hh-SZ
	for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YfSIL-0000Nb-1z
	for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:07:57 -0400
Received: from mail-ig0-f180.google.com ([209.85.213.180]:38857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YfSIK-0000NV-UL
	for qemu-devel@nongnu.org; Tue, 07 Apr 2015 08:07:52 -0400
Received: by igbqf9 with SMTP id qf9so9150626igb.1
	for <qemu-devel@nongnu.org>; Tue, 07 Apr 2015 05:07:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <55234469.9060404@huawei.com>
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428346052.2973.26.camel@deneb.redhat.com>
	<55234469.9060404@huawei.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 7 Apr 2015 13:07:31 +0100
Message-ID: <CAFEAcA8M8pDu3T52ixjuSPbKWFoy4jzEKriFm-yZ187Yba9SLA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and
 expose it to guest over fw_cfg on ARM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: hangaohuai@huawei.com, Igor Mammedov <imammedo@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, "Michael S. Tsirkin" <mst@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Hanjun Guo <hanjun.guo@linaro.org>, Mark Salter <msalter@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 7 April 2015 at 03:43, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> The ACPI table entry:
>             Method (_CBA, 0, NotSerialized)  // _CBA: Configuration Base Address
>             {
>                 Return (0x3F000000)
>             }
>             Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>             {
>                 Name (RBUF, ResourceTemplate ()
>                 {
>                     WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
>                         0x0000,             // Granularity
>                         0x0000,             // Range Minimum
>                         0x000F,             // Range Maximum
>                         0x0000,             // Translation Offset
>                         0x0010,             // Length
>                         ,, )
>                     DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
>                         0x00000000,         // Granularity
>                         0x10000000,         // Range Minimum
>                         0x3EFF0000,         // Range Maximum
>                         0x00000000,         // Translation Offset
>                         0x2EFF0000,         // Length

In all the other sections, the Length entry is (rangemax - rangemin) + 1,
but in this one it is not, which suggests an error. Probably your
rangemax here is wrong, since 0x3eff0000 is actually the first address
in the IO window.

(If ACPI is effectively describing the length of the range in
two separate places, it's a shame it doesn't sanity check that
they both agree...)

-- PMM