From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfZNJ-0004jR-N6 for qemu-devel@nongnu.org; Thu, 23 May 2013 13:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfZNH-0001mT-Ao for qemu-devel@nongnu.org; Thu, 23 May 2013 13:32:25 -0400 Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:59068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfZNG-0001lb-RB for qemu-devel@nongnu.org; Thu, 23 May 2013 13:32:22 -0400 Received: by mail-la0-f44.google.com with SMTP id fr10so3541463lab.3 for ; Thu, 23 May 2013 10:32:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1369133851-1894-5-git-send-email-pbonzini@redhat.com> References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-5-git-send-email-pbonzini@redhat.com> From: Peter Maydell Date: Thu, 23 May 2013 18:32:01 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jan.kiszka@gmail.com, qemu-devel@nongnu.org, David Gibson On 21 May 2013 11:57, Paolo Bonzini wrote: > It is not used anywhere. So does this get deleted just because it's not used, or because it gets in the way of patches later in the series. As far as I can tell the st*_phys_notdirty() are for TCG to update page table entries with accessed/modified bits, and I don't see any reason we wouldn't have targets that need to update a 64 bit page table descriptor rather than just 32 bits of it. thanks -- PMM