From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bBKTJ-0001yl-J5
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 07:19:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bBKTE-0000Ui-Jb
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 07:19:28 -0400
Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:36201)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bBKTE-0000UQ-F7
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 07:19:24 -0400
Received: by mail-vk0-x230.google.com with SMTP id g67so92981405vkb.3
	for <qemu-devel@nongnu.org>; Fri, 10 Jun 2016 04:19:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <180514a5994d4b96e0c25499d90c895ab489b762.1463093051.git.alistair.francis@xilinx.com>
References: <cover.1463093051.git.alistair.francis@xilinx.com>
	<180514a5994d4b96e0c25499d90c895ab489b762.1463093051.git.alistair.francis@xilinx.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 10 Jun 2016 12:19:04 +0100
Message-ID: <CAFEAcA8PxnKQDyz7BgmWCSZfhJwu-rU33Wfor3pHYfNptAYdQg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v6 08/13] xilinx_zynq: Connect devcfg to
 the Zynq machine model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, Edgar Iglesias <edgar.iglesias@xilinx.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>

On 12 May 2016 at 23:46, Alistair Francis <alistair.francis@xilinx.com> wrote:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> V4:
>  - Small corrections to the device model logic
>
>  hw/arm/xilinx_zynq.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index 98b17c9..ffea3be 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -293,6 +293,14 @@ static void zynq_init(MachineState *machine)
>          sysbus_connect_irq(busdev, n + 1, pic[dma_irqs[n] - IRQ_OFFSET]);
>      }
>
> +    dev = qdev_create(NULL, "xlnx.ps7-dev-cfg");
> +    object_property_add_child(qdev_get_machine(), "xlnx-devcfg", OBJECT(dev),
> +                              NULL);

Why do we need to do this?

> +    qdev_init_nofail(dev);
> +    busdev = SYS_BUS_DEVICE(dev);
> +    sysbus_connect_irq(busdev, 0, pic[40 - IRQ_OFFSET]);
> +    sysbus_mmio_map(busdev, 0, 0xF8007000);
> +
>      zynq_binfo.ram_size = ram_size;
>      zynq_binfo.kernel_filename = kernel_filename;
>      zynq_binfo.kernel_cmdline = kernel_cmdline;
> --
> 2.7.4

thanks
-- PMM