All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: David CARLIER <devnexen@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] build: Haiku build fix
Date: Fri, 26 Jun 2020 09:41:34 +0100	[thread overview]
Message-ID: <CAFEAcA8RJZi-r9VwOzH0Rr=YWdxL5jJBw4JZzA5q=qmP4TvaXw@mail.gmail.com> (raw)
In-Reply-To: <CA+XhMqzX=OaRgxQbHKU82K2WhTBwL44sr+wpGKSjZWqaehLyJQ@mail.gmail.com>

On Thu, 25 Jun 2020 at 22:31, David CARLIER <devnexen@gmail.com> wrote:
>
> From 78706a28c6aa8b5e522b5781588b38961d79d6f6 Mon Sep 17 00:00:00 2001
> From: David Carlier <devnexen@gmail.com>
> Date: Thu, 25 Jun 2020 19:32:42 +0000
> Subject: [PATCH] build: haiku system build fix
>
> Most of missing features resides in the bsd library.
> Also defining constant equivalence.
>
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  configure            | 34 ++++++++++++++++++++++++++++++++--
>  include/qemu/bswap.h |  2 ++
>  include/qemu/osdep.h |  4 ++++
>  os-posix.c           |  4 ++++
>  util/Makefile.objs   |  2 +-
>  util/compatfd.c      |  2 ++
>  util/main-loop.c     |  1 +
>  util/oslib-posix.c   | 20 ++++++++++++++++++++
>  util/qemu-openpty.c  |  2 +-
>  9 files changed, 67 insertions(+), 4 deletions(-)

Would you mind splitting this into a patchset which has
one patch for each fix, please? So a patch which makes
configure probe for openpty-in-pty.h and use it,
another patch for the mlockall change, another patch
for haiku-implementation-of-qemu_init_exec_dir, and so on.
We generally prefer each commit to do one thing; it's
easier to review.

thanks
-- PMM


      parent reply	other threads:[~2020-06-26  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 21:30 [PATCH v3] build: Haiku build fix David CARLIER
2020-06-26  5:55 ` Thomas Huth
2020-06-26  8:41 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8RJZi-r9VwOzH0Rr=YWdxL5jJBw4JZzA5q=qmP4TvaXw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=devnexen@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.