From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpHH9-0005yH-Dj for qemu-devel@nongnu.org; Fri, 05 Aug 2011 06:05:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpHH3-00007L-0H for qemu-devel@nongnu.org; Fri, 05 Aug 2011 06:05:07 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:48377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpHH2-00007G-Pb for qemu-devel@nongnu.org; Fri, 05 Aug 2011 06:05:00 -0400 Received: by pzk37 with SMTP id 37so4288759pzk.29 for ; Fri, 05 Aug 2011 03:04:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1312148458-499-1-git-send-email-j.schauer@email.de> References: <1312148458-499-1-git-send-email-j.schauer@email.de> Date: Fri, 5 Aug 2011 11:04:59 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] introduce environment variables for all qemu-user options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schauer Cc: 632192@bugs.debian.org, Riku Voipio , qemu-devel@nongnu.org, Vagrant Cascadian On 31 July 2011 22:40, Johannes Schauer wrote: > Rework option parsing code for linux-user in a table-driven manner to allow > environment variables for all commandline options. > > Also generate usage() output from option table. Thanks for this, it looks good. A couple of minor points: (1) what's the rationale for having most of the things the arg-parsing-functions change be global variables but passing envlist as an argument to each function? It's only used by two of the functions so maybe that should just be a global too. (2) scripts/checkpatch.pl complains about a number of formatting nits; mostly these are in existing code you've just moved around, but I think it's worth fixing them in passing anyway. -- PMM