From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771C6C636C9 for ; Sat, 17 Jul 2021 23:36:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CB18610F9 for ; Sat, 17 Jul 2021 23:36:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CB18610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4tqu-0006v8-EW for qemu-devel@archiver.kernel.org; Sat, 17 Jul 2021 19:36:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4tpP-0004cI-9t for qemu-devel@nongnu.org; Sat, 17 Jul 2021 19:34:39 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:42683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4tpN-00012J-SE for qemu-devel@nongnu.org; Sat, 17 Jul 2021 19:34:39 -0400 Received: by mail-ej1-x635.google.com with SMTP id hd33so21241735ejc.9 for ; Sat, 17 Jul 2021 16:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YoYCO3dhMVBUip+An6H/5w/6LGA0I9NnHUXASn91iEU=; b=cwhmIboUWt5JU3YW+YO+tAp91etXcmY9tGzdHYRMv/FUWCrAK3PXKqSU9Hi8YLZKsD vyPdMjiT0wyV+k7xJK/ZZ3UcpDiI7q5Ejg+ePjF4iNSHi7nbYGPmjA+jktTVGP2ktn++ /dkkkz2ocJS/GzSrmotnGMR53nHmovvtPrASKPQNSIcvDkp5qDMEBfmX4ralP4aKIsk3 7BDfy7sEsO1xxHHvr2EPkmLTXi8GviuRVWrG0tt5CfuQBDwQRjQifdHOB5cCS/1racAH J98ZgrWzCil7ASxkadG0oZBnd6sh3LdUMSIHX1wtHhHWW/9kebSXf7ClyaX0xF0rl5wm Qtog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YoYCO3dhMVBUip+An6H/5w/6LGA0I9NnHUXASn91iEU=; b=Xaoze2Ib5GUBbzsoqlzd6R+HW9mMLjUc+Ayr+tOhJCKw7Cu3VJI7S3r9un3ztZ2s40 ZkqRDcm0Jf6k+Wsx62C0kxrENavEhi2Gn+vmbWhKxgWV3yIH0TBUeiVpwfGYtNLECeSE tCBeRVGLiiyMe0u9qectOAZ4UzFOfOfQMRnZNTsCdkjXcwxN6191ENvKCPGDowy6XScG wVZdLvI7tubccvErGX5nMjY/CEo3mWv7QbYAFjIzcWf+fs11+mq1c5t0qoYDK5uOXGtq RnYN8PitRE23ASjgl1s6L1CrcJTc2OvqIKJKxcjT4Y3JZBTwf/Who9agIjB+ChDsTf6x JPcA== X-Gm-Message-State: AOAM533c9JsS6KkPYWYEDWq6kCPeNVhSwrHMprE9uDbbgojurAlMggZw yB+6pgxo1KZkrP6rOUJPqrzbjiz6feASjh6SiTmMhw== X-Google-Smtp-Source: ABdhPJwsJHb+78SIJm2k49QHTeDWiQTVk4PLM2YupjTgm1E2O7rI4vHja5NpcZOP52uykSewfln90H2abSdcinsaNrs= X-Received: by 2002:a17:907:3e02:: with SMTP id hp2mr19472218ejc.4.1626564876452; Sat, 17 Jul 2021 16:34:36 -0700 (PDT) MIME-Version: 1.0 References: <20210717221851.2124573-1-richard.henderson@linaro.org> <20210717221851.2124573-10-richard.henderson@linaro.org> In-Reply-To: <20210717221851.2124573-10-richard.henderson@linaro.org> From: Peter Maydell Date: Sun, 18 Jul 2021 00:33:56 +0100 Message-ID: Subject: Re: [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2 To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , =?UTF-8?B?QWxleCBCZW5uw6ll?= , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > The actual number of bytes advanced need not be 100% exact, > but we should not cross a page when the insn would not. > > If mips16 or mips32e are enabled, the minimum insn size is 2. > > Signed-off-by: Richard Henderson > --- > target/mips/tcg/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c > index fd980ea966..ef00fbd2ac 100644 > --- a/target/mips/tcg/translate.c > +++ b/target/mips/tcg/translate.c > @@ -16192,7 +16192,7 @@ static bool mips_tr_breakpoint_check(DisasContextBase *dcbase, CPUState *cs, > * properly cleared -- thus we increment the PC here so that > * the logic setting tb->size below does the right thing. > */ > - ctx->base.pc_next += 4; > + ctx->base.pc_next += 2; > return true; > } > Reviewed-by: Peter Maydell thanks -- PMM