From: Peter Maydell <peter.maydell@linaro.org>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH V2 4/4] target-arm: Add missing SP_ELx register definition
Date: Tue, 27 Jan 2015 19:03:07 +0000 [thread overview]
Message-ID: <CAFEAcA8VDn_ZGHR4fZV5N4Hv1toY+Qu94EFbnRrmTx925k1TMw@mail.gmail.com> (raw)
In-Reply-To: <1422029835-4696-5-git-send-email-greg.bellows@linaro.org>
On 23 January 2015 at 16:17, Greg Bellows <greg.bellows@linaro.org> wrote:
> Added CP register definitions for SP_EL1 and SP_EL2.
>
> Signed-off-by: Greg Bellows <greg.bellows@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> ---
>
> v1 -> v2
> - Remove unnecessary accessfn for SP_EL1/2
> - Revert SP_EL0 accessfn name to sp_el0_access
> ---
> target-arm/helper.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 29f3b62..79c54a9 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -2329,6 +2329,10 @@ static const ARMCPRegInfo v8_cp_reginfo[] = {
> .access = PL1_RW, .accessfn = sp_el0_access,
> .type = ARM_CP_NO_MIGRATE,
> .fieldoffset = offsetof(CPUARMState, sp_el[0]) },
> + { .name = "SP_EL1", .state = ARM_CP_STATE_AA64,
> + .opc0 = 3, .opc1 = 4, .crn = 4, .crm = 1, .opc2 = 0,
> + .access = PL2_RW, .type = ARM_CP_NO_MIGRATE,
> + .fieldoffset = offsetof(CPUARMState, sp_el[1]) },
> { .name = "SPSel", .state = ARM_CP_STATE_AA64,
> .opc0 = 3, .opc1 = 0, .crn = 4, .crm = 2, .opc2 = 0,
> .type = ARM_CP_NO_MIGRATE,
> @@ -2410,6 +2414,10 @@ static const ARMCPRegInfo v8_el2_cp_reginfo[] = {
> .access = PL2_RW, .writefn = vbar_write,
> .fieldoffset = offsetof(CPUARMState, cp15.vbar_el[2]),
> .resetvalue = 0 },
> + { .name = "SP_EL2", .state = ARM_CP_STATE_AA64,
> + .opc0 = 3, .opc1 = 6, .crn = 4, .crm = 1, .opc2 = 0,
> + .access = PL3_RW, .type = ARM_CP_NO_MIGRATE,
> + .fieldoffset = offsetof(CPUARMState, sp_el[2]) },
> REGINFO_SENTINEL
> };
As I was assembling my target-arm queue I found that this patch
and the 'split ARM_CP_NO_MIGRATE' patch semantically conflict;
since this patch happened to be earlier in the queue than that
one, I've resolved this by adding changes to the 'split' patch
which change these ARM_CP_NO_MIGRATE uses to ARM_CP_ALIAS, in
line with how we handled the SP_EL0 regdef.
thanks
-- PMM
next prev parent reply other threads:[~2015-01-27 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 16:17 [Qemu-devel] [PATCH V2 0/4] target-arm: Initial ARMv8 extended EL support Greg Bellows
2015-01-23 16:17 ` [Qemu-devel] [PATCH V2 1/4] target-arm: Fix RVBAR_EL1 register encoding Greg Bellows
2015-01-23 16:25 ` Peter Maydell
2015-01-23 16:17 ` [Qemu-devel] [PATCH V2 2/4] target-arm: Add extended RVBAR support Greg Bellows
2015-01-23 16:17 ` [Qemu-devel] [PATCH V2 3/4] target-arm: Change reset to highest available EL Greg Bellows
2015-01-23 16:24 ` Peter Maydell
2015-01-23 16:17 ` [Qemu-devel] [PATCH V2 4/4] target-arm: Add missing SP_ELx register definition Greg Bellows
2015-01-27 19:03 ` Peter Maydell [this message]
2015-01-27 19:07 ` Greg Bellows
2015-01-27 14:36 ` [Qemu-devel] [PATCH V2 0/4] target-arm: Initial ARMv8 extended EL support Sergey Fedorov
2015-01-27 14:39 ` Greg Bellows
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8VDn_ZGHR4fZV5N4Hv1toY+Qu94EFbnRrmTx925k1TMw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=greg.bellows@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.