From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1atM-0003Fm-9f for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1atL-0002wR-Ak for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:22:24 -0400 Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:35902) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1atK-0002w8-U0 for qemu-devel@nongnu.org; Tue, 01 Nov 2016 11:22:23 -0400 Received: by mail-vk0-x231.google.com with SMTP id p9so30174678vkd.3 for ; Tue, 01 Nov 2016 08:22:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1477850917-1214-1-git-send-email-mst@redhat.com> References: <1477850917-1214-1-git-send-email-mst@redhat.com> From: Peter Maydell Date: Tue, 1 Nov 2016 15:22:01 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: QEMU Developers On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to f082ec0225bd15c71e0b4697d2df3af7bad65d7f: > > acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:06:25 +0200) > > ---------------------------------------------------------------- > virtio, pc: fixes and features > > nvdimm hotplug support > virtio migration and ioeventfd rework > virtio crypto device > ipmi fixes > > Signed-off-by: Michael S. Tsirkin > Hi; this fails to build on OSX with format string issues: /Users/pm215/src/qemu-for-merges/hw/virtio/virtio-crypto.c:770:20: error: format specifies type 'unsign ed short' but the argument has type 'uint32_t' (aka 'unsigned int') [-Werror,-Wformat] vcrypto->max_queues, VIRTIO_QUEUE_MAX); ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/pm215/src/qemu-for-merges/include/qapi/error.h:163:35: note: expanded from macro 'error_setg' (fmt), ## __VA_ARGS__) ^ Fun fact: in struct vhost_dev, max_queues is a uint64_t; in struct VirtIONet it is a uint16_t; and in VirtIOCrypto it is a uint32_t... thanks -- PMM