From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TQJ7X-0003oj-0a
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 10:36:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TQJ7Q-0008QZ-Td
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 10:36:46 -0400
Received: from mail-ia0-f173.google.com ([209.85.210.173]:34405)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1TQJ7Q-0008QA-P8
	for qemu-devel@nongnu.org; Mon, 22 Oct 2012 10:36:40 -0400
Received: by mail-ia0-f173.google.com with SMTP id m10so2166758iam.4
	for <qemu-devel@nongnu.org>; Mon, 22 Oct 2012 07:36:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <670dd5d1bc09fa081b57c00b5c1c4ce03725242c.1350889929.git.peter.crosthwaite@xilinx.com>
References: <cover.1350889929.git.peter.crosthwaite@xilinx.com>
	<670dd5d1bc09fa081b57c00b5c1c4ce03725242c.1350889929.git.peter.crosthwaite@xilinx.com>
Date: Mon, 22 Oct 2012 15:36:39 +0100
Message-ID: <CAFEAcA8X68kfOWKOGWgDQJaBkfpSnSq-yemfOzYoxo3veWd9rw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 3/6] pflash_cfi0x: QOMified
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: vineshp@xilinx.com, edgar.iglesias@gmail.com, john.williams@xilinx.com, qemu-devel@nongnu.org, pbonzini@redhat.com

On 22 October 2012 08:19, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> QOMified the pflash_cfi0x so machine models can connect them up in custom ways.
>
> Kept the pflash_cfi0x_register functions as is. They can still be used to
> create a flash straight onto system memory.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

> --- a/hw/pflash_cfi01.c
> +++ b/hw/pflash_cfi01.c
> @@ -42,6 +42,7 @@
>  #include "qemu-timer.h"
>  #include "exec-memory.h"
>  #include "host-utils.h"
> +#include "sysbus.h"
>
>  #define PFLASH_BUG(fmt, ...) \
>  do { \
> @@ -60,21 +61,29 @@ do {                                               \
>  #endif
>
>  struct pflash_t {
> +    SysBusDevice busdev;
>      BlockDriverState *bs;
> -    target_phys_addr_t sector_len;
> -    int width;
> +    uint32_t nb_blocs;
> +    /* FIXME: get rid of target_phys_addr_t usage */

This comment is no longer necessary. If you delete it then
you can mark the next version as
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM