From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIMbb-0000gh-4G for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:19:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIMbW-0000Ms-9A for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:19:47 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:54808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIMbW-0000Mf-1d for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:19:42 -0500 Received: by mail-lb0-f182.google.com with SMTP id n15so1289684lbi.13 for ; Tue, 25 Feb 2014 10:19:41 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1393347170-28502-3-git-send-email-a.rigo@virtualopensystems.com> References: <1393347170-28502-1-git-send-email-a.rigo@virtualopensystems.com> <1393347170-28502-3-git-send-email-a.rigo@virtualopensystems.com> From: Peter Maydell Date: Tue, 25 Feb 2014 18:19:20 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alvise Rigo Cc: "tech@virtualopensystems.com" , QEMU Developers On 25 February 2014 16:52, Alvise Rigo wrote: > The value of this flag indicates the execution mode of the CPU prior the > migration. It is used to handle the KVM <-> TCG migration. > > Signed-off-by: Alvise Rigo > --- > target-arm/cpu-qom.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h > index afbd422..6819bfc 100644 > --- a/target-arm/cpu-qom.h > +++ b/target-arm/cpu-qom.h > @@ -102,6 +102,9 @@ typedef struct ARMCPU { > */ > uint32_t kvm_target; > > + /* true if this cpu is using KVM. Read and set in cpu_pre/post_load */ > + bool running_kvm; This is definitely wrong. We should not care whether either end of the migration connection is using KVM. thanks -- PMM