All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Pekka Enberg <penberg@iki.fi>, qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v1 3/3] raspi: Add "raspi3" machine type
Date: Thu, 15 Feb 2018 13:18:49 +0000	[thread overview]
Message-ID: <CAFEAcA8Zhih61YZNBEQQOFv_XKWknw7oN80pQbK+NgcB1mEsYQ@mail.gmail.com> (raw)
In-Reply-To: <a3f95aa2-3a13-8a67-4fe2-b7da6eace585@amsat.org>

On 15 February 2018 at 13:14, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 02/15/2018 09:49 AM, Philippe Mathieu-Daudé wrote:
>> On 02/15/2018 09:39 AM, Peter Maydell wrote:
>>> On 8 February 2018 at 05:50, Pekka Enberg <penberg@iki.fi> wrote:
>
> Now I remember why I hesitated with this patch,
>
> This part {
>
>>>> +    mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a53");
>>>> +    mc->max_cpus = BCM2836_NCPUS;
>>>> +    mc->min_cpus = BCM2836_NCPUS;
>>>> +    mc->default_cpus = BCM2836_NCPUS;
>
> } is the BCM2837 SoC, very similar to the BCM2836.

Yeah, we had a whole go-around about whether we should have a
BCM2837 object or just make the BCM2836 object have a configurable
CPU type. You could argue either way...

thanks
-- PMM

  reply	other threads:[~2018-02-15 13:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  5:50 [Qemu-devel] [PATCH v1 0/3] Raspberry Pi 3 support Pekka Enberg
2018-02-08  5:50 ` [Qemu-devel] [PATCH v1 2/3] raspi: " Pekka Enberg
2018-02-08  5:50 ` [Qemu-devel] [PATCH v1 3/3] raspi: Add "raspi3" machine type Pekka Enberg
2018-02-15 12:39   ` Peter Maydell
2018-02-15 12:49     ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-02-15 13:14       ` Philippe Mathieu-Daudé
2018-02-15 13:18         ` Peter Maydell [this message]
2018-02-15 13:28           ` Philippe Mathieu-Daudé
2018-02-16  7:08     ` [Qemu-devel] " Pekka Enberg
     [not found] ` <20180208055039.24666-2-penberg@iki.fi>
2018-02-15 11:48   ` [Qemu-devel] [PATCH v1 1/3] bcm2836: Make CPU type configurable Peter Maydell
2018-02-16  7:04     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8Zhih61YZNBEQQOFv_XKWknw7oN80pQbK+NgcB1mEsYQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=penberg@iki.fi \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.