From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB5BC433ED for ; Thu, 13 May 2021 12:57:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FBD061264 for ; Thu, 13 May 2021 12:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FBD061264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhAuB-0001zF-EC for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 08:57:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhAj2-0004jx-VR for qemu-devel@nongnu.org; Thu, 13 May 2021 08:46:00 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:40845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhAj0-00071Q-BG for qemu-devel@nongnu.org; Thu, 13 May 2021 08:46:00 -0400 Received: by mail-ed1-x532.google.com with SMTP id c22so30803981edn.7 for ; Thu, 13 May 2021 05:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZnAZ/nP9V5EdBdZL2ikFX+lherf5ZQMWDV1UogZdwlA=; b=N5Vbp3+oB6c0I71oAVyd56O1FLmXwT2wjugLon9FeuOYEly1bwNmKuhPY05qF2rDX/ GQE6cJEpsI0ifuOeLrmtGB7HU8Gq8z3MShJkkOaKxYmgN1KCUIuNtnK6DJW885D5/hBZ 55cH0yXy9mjkhayqMaDzV/dEWZcW3Lw7iq3kMIRzaQYaCfURNKXPL6nnixxbSF7SgaQD IA0Vj6vhAoYJnGOFrrAMp+Uv4fo8DsWsfWi2Jj5igadJM6OxtZm/gwtd5i41D6zfHxzb Tpk56ThFWk1W2F6mC63AXt9dcxNV4hRCMXt9ItS/uqKbWwGoX94FcQ9niBo09tfMDGn8 peZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZnAZ/nP9V5EdBdZL2ikFX+lherf5ZQMWDV1UogZdwlA=; b=O6XyWkl5lPezqae3ffOJf/KaZ1apu3puO9M2cuA4M+dUm8vyo8/3nGAPuaziOh9CfI pAxESLSz37EKFJLfJVB9ogtV618UfK+Rbiy38V2GZrP3ZWfx17JapNowCxYNVQaKPcHU gLjvPpOPdNXVUyla7ZDdNS7lbypNTUzD/b+02Edie0+h+JiNkXu+SeMYaKp4HReSGVwF NgS2vdzjh8oiDMLEPjFUhtwzKDtfJ3iECMmBrS6t5aQFe6GNyNg/l2sBZf8yB8Vt45ji UGR1lxsSeYhn84ux7pecOHNnjYEqKiEECTJjypyAeFAqD6RrAIdIeEGYlZBvS1ngD27N Am1w== X-Gm-Message-State: AOAM530GwwXS/Zlm/AtbwEBNWci7fc4A+BWROdT3oJHfR/I2AYxpY52u xgsDp9auSbqPP+rkKRClSUecS620meXt3pziBpDA3Q== X-Google-Smtp-Source: ABdhPJxvbyJ6QV3UyLwLybW3/VEybayc+G2B/4NxY8/7/JDS1poMqRoNqAvYHLksUFWLGGhjiWUKLmL1j7rZfpgZc9E= X-Received: by 2002:a05:6402:3548:: with SMTP id f8mr49520272edd.251.1620909956858; Thu, 13 May 2021 05:45:56 -0700 (PDT) MIME-Version: 1.0 References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-57-richard.henderson@linaro.org> In-Reply-To: <20210430202610.1136687-57-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 13 May 2021 13:45:45 +0100 Message-ID: Subject: Re: [PATCH v6 56/82] target/arm: Implement SVE2 saturating multiply (indexed) To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Apr 2021 at 22:24, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h | 5 +++++ > target/arm/sve.decode | 12 ++++++++++++ > target/arm/sve_helper.c | 20 ++++++++++++++++++++ > target/arm/translate-sve.c | 19 +++++++++++++++---- > 4 files changed, 52 insertions(+), 4 deletions(-) > > +#define DO_ZZX(NAME, TYPEW, TYPEN, HW, HN, OP) \ > +void HELPER(NAME)(void *vd, void *vn, void *vm, uint32_t desc) \ > +{ \ > + intptr_t i, j, oprsz = simd_oprsz(desc); \ > + intptr_t sel = extract32(desc, SIMD_DATA_SHIFT, 1) * sizeof(TYPEN); \ > + intptr_t idx = extract32(desc, SIMD_DATA_SHIFT + 1, 3) * sizeof(TYPEN); \ > + for (i = 0; i < oprsz; i += 16) { \ > + TYPEW mm = *(TYPEN *)(vm + i + idx); \ Again, not sure why we don't need an H macro here. > + for (j = 0; j < 16; j += sizeof(TYPEW)) { \ > + TYPEW nn = *(TYPEN *)(vn + HN(i + j + sel)); \ > + *(TYPEW *)(vd + HW(i + j)) = OP(nn, mm); \ > + } \ > + } \ > +} Otherwise Reviewed-by: Peter Maydell thanks -- PMM