From: Peter Maydell <peter.maydell@linaro.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <shannon.zhao@linaro.org>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends
Date: Fri, 17 Apr 2015 15:00:45 +0100 [thread overview]
Message-ID: <CAFEAcA8b-WBSDNvb5bhGSuwF9ojjG8R2MrnSHautPa-CgTY2_Q@mail.gmail.com> (raw)
In-Reply-To: <20150417154335.7fa224ce.cornelia.huck@de.ibm.com>
On 17 April 2015 at 14:43, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> On Fri, 17 Apr 2015 20:13:42 +0800
> Shannon Zhao <shannon.zhao@linaro.org> wrote:
>
> [Some questions may be silly, but I'm not familiar with the virtio-mmio
> code]
>
>> The reason to do this is that the virtio-net-device can't expose host
>> features to guest while using virtio-mmio. So the performance is low.
>
> So how does virtio-mmio expose any host features?
The features are properties of the backend, not the transport.
So for devices where we didn't set these up as "properties
exist on the backend and the compatibility transport+backend
wrapper devices just forward those properties to the backend",
you can't set the properties. We got this right for some of
the backends (eg blk) but not all of them, I think.
NB: I haven't looked at the code in these patches yet, so this is
just the way I think it ought to work... it's not clear to me
yet why we need to change the s390 transports in this patchset.
-- PMM
next prev parent reply other threads:[~2015-04-17 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 12:13 [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends Shannon Zhao
2015-04-17 12:13 ` [Qemu-devel] [PATCH 1/4] hw/s390x/virtio-ccw: Add virtio_ccw_device_plugged for virtio-ccw Shannon Zhao
2015-04-17 13:44 ` Cornelia Huck
2015-04-17 14:50 ` Shannon Zhao
2015-04-17 15:33 ` Peter Maydell
2015-04-18 1:36 ` Shannon Zhao
2015-04-17 12:13 ` [Qemu-devel] [PATCH 2/4] hw/s390x/s390-virtio-bus: Add virtio_s390_device_plugged for s390-virtio Shannon Zhao
2015-04-17 12:13 ` [Qemu-devel] [PATCH 3/4] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net Shannon Zhao
2015-04-17 14:05 ` Peter Maydell
2015-04-17 14:50 ` Shannon Zhao
2015-04-17 15:03 ` Peter Maydell
2015-04-17 12:13 ` [Qemu-devel] [PATCH 4/4] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi Shannon Zhao
2015-04-17 13:43 ` [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends Cornelia Huck
2015-04-17 14:00 ` Peter Maydell [this message]
2015-04-20 8:54 ` Cornelia Huck
2015-04-20 9:02 ` Peter Maydell
2015-04-20 9:12 ` Michael S. Tsirkin
2015-04-20 12:14 ` Cornelia Huck
2015-04-20 12:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8b-WBSDNvb5bhGSuwF9ojjG8R2MrnSHautPa-CgTY2_Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.