From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1c1DqM-0005Er-Cc
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:45:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1c1DqL-0006aQ-K2
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:45:46 -0400
Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:36630)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)
	id 1c1DqL-0006aH-FR
	for qemu-devel@nongnu.org; Mon, 31 Oct 2016 10:45:45 -0400
Received: by mail-vk0-x234.google.com with SMTP id p9so4303944vkd.3
	for <qemu-devel@nongnu.org>; Mon, 31 Oct 2016 07:45:45 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1477676782-21378-1-git-send-email-joserz@linux.vnet.ibm.com>
References: <1477676782-21378-1-git-send-email-joserz@linux.vnet.ibm.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 31 Oct 2016 14:45:24 +0000
Message-ID: <CAFEAcA8cAjMmRNk7Gk=qf_iQFjYMnNzYYyW6ve0zFL0AAdx9yA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH Risu 0/3] Risu support for PPC64LE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 28 October 2016 at 18:46, Jose Ricardo Ziviani
<joserz@linux.vnet.ibm.com> wrote:
> From: Jose Ricardo Ziviani <joserz@br.ibm.com>
>
> This is an initial effort to have RISU working for PPC64LE.
>
> I also made some changes to isolate risugen, creating two modules
> (risugen_arm.pm and risugen_ppc64le.pm) to implement specific
> instructions in it.
>
> Suggestions are welcome! :)
>
> TODOS:
>  - improve load/store instruction generation
>  - improve initial random values for FP and Vector regs.
>
> Jose Ricardo Ziviani (3):
>   Implementation of ppc64le module for risugen and risufile
>   Isolates Arm specific subroutines out from risugen main file
>   Initial implemention for ppc64le

Thanks for this patchset. The modularisation of architecture
support in particular is something we've needed for a while.

I've made a few first-pass review comments and some suggestions
for breaking up the patchset to make it a bit easier to review.
I'll try to go easy on the review requirements since this is
fundamentally just a test tool.

Getting the copyright statements right is really important
though -- I can't apply it without those being fixed.

thanks
-- PMM