From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF829C433ED for ; Thu, 13 May 2021 13:07:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5227861108 for ; Thu, 13 May 2021 13:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5227861108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhB3N-00066i-9z for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 09:07:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhAyc-0008Ue-5t for qemu-devel@nongnu.org; Thu, 13 May 2021 09:02:06 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:37698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhAyY-0008KL-34 for qemu-devel@nongnu.org; Thu, 13 May 2021 09:02:04 -0400 Received: by mail-ej1-x62f.google.com with SMTP id w3so39758918ejc.4 for ; Thu, 13 May 2021 06:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jplbw6F74bu5if+ZTZj8T120Xzd+C2UuwKzdhRRM4Kg=; b=p9usuX2SuFixE6TwaJOsPtQ7AeuYc+AnJfG1bb5xixDmPJW7mGyibEvVboZ5gS3n05 Q2QpibdWxOwQlt8rOEy7BxXQ6WSMG2R3PaUlYwY1r6MSTH8bmL6/QtRhTrSZA/9/c7QX 6xESQou3k6Q1ZQC9hhKrTk1lFTrdkLnl6eYHFU3DHr+ENOsdxkPQNEgKiDNTxs7iXAh2 M3HF9+Wud4D2KtfazdwPpCbNtsgX+A00tg9dfL0rAQ/pmrKyTzsWIr0bwZ0IANvj0z1z H1LeS3HwNjN94prg6HlVlLZLyL7y9l2W4HDUUxZYYJPn9kI3QMxj/tSMfBO/VzsZ+6hA /fiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jplbw6F74bu5if+ZTZj8T120Xzd+C2UuwKzdhRRM4Kg=; b=ZoqJcuNDXhrIie7CSZwT+emzBUOxVVR/EkAlbiRoXB89MRF83Mi+BTuahIXuxg9zRy 4B6SXLkwFCCPaPKx2JiEvncMizWZBy2rat/fue2G7RnTborzDBGE5vhksWWb9I4aJbFF odi7F2bp9EOcKVFLkIN4ePRDP4P9xpFO2ibS+9sCxRIr4egPRA8HXqGs9sen3b8H0+0c vCF0P/i9mUapJU2ULsUxBn//6Jj6iNmrbhM3VzcM72TrwUlwUrEQsms5XDIHaH8ibJke P9H8bh1/mvFG3yGWz63Wi7rOe+Vsz2qDqtjLeCQBLZ9SOdXcMJ+ighH3RV3IFWqn1OEl SKRQ== X-Gm-Message-State: AOAM532UNUW3neS82086WtcSMQIOPJmD4yH1G7KJ6uOxC3HVR88W1s5v pSGjQJ/fBTByQRT06B7vRGJ4lIM8B0G6ZOtX7AshEbb4qfc= X-Google-Smtp-Source: ABdhPJyv/pTXCxmo9RJWSWDgdh0dc0ZF14uBrB7zLE57uPNbejhD8yeFdZgduJ/tASQld7Bk4xBq/Avh2FNp11L7iLI= X-Received: by 2002:a17:906:254c:: with SMTP id j12mr12999110ejb.4.1620910919128; Thu, 13 May 2021 06:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-61-richard.henderson@linaro.org> In-Reply-To: <20210430202610.1136687-61-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 13 May 2021 14:01:47 +0100 Message-ID: Subject: Re: [PATCH v6 60/82] target/arm: Implement SVE mixed sign dot product To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h | 2 ++ > target/arm/sve.decode | 4 ++++ > target/arm/translate-sve.c | 16 ++++++++++++++++ > target/arm/vec_helper.c | 18 ++++++++++++++++++ > 4 files changed, 40 insertions(+) > > diff --git a/target/arm/helper.h b/target/arm/helper.h > index e4c6458f98..86f938c938 100644 > --- a/target/arm/helper.h > +++ b/target/arm/helper.h > @@ -612,6 +612,8 @@ DEF_HELPER_FLAGS_5(gvec_sdot_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) > DEF_HELPER_FLAGS_5(gvec_udot_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) > DEF_HELPER_FLAGS_5(gvec_sdot_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) > DEF_HELPER_FLAGS_5(gvec_udot_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) > +DEF_HELPER_FLAGS_5(gvec_usdot_b, TCG_CALL_NO_RWG, > + void, ptr, ptr, ptr, ptr, i32) This is one of those places where I'd take the long line even if checkpatch complains, just to maintain the parallelism with the preceding lines, but wrapping is fine too. Reviewed-by: Peter Maydell thanks -- PMM