From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT9Rl-0001EC-MV for qemu-devel@nongnu.org; Tue, 09 Feb 2016 09:39:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT9Rk-0007eN-SP for qemu-devel@nongnu.org; Tue, 09 Feb 2016 09:39:17 -0500 Received: from mail-vk0-x236.google.com ([2607:f8b0:400c:c05::236]:36455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT9Rk-0007eI-O9 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 09:39:16 -0500 Received: by mail-vk0-x236.google.com with SMTP id c3so71608908vkb.3 for ; Tue, 09 Feb 2016 06:39:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56B9F9B8.4000403@redhat.com> References: <1455027417-32278-1-git-send-email-pbonzini@redhat.com> <20160209142120.GM24614@redhat.com> <56B9F9B8.4000403@redhat.com> From: Peter Maydell Date: Tue, 9 Feb 2016 14:38:56 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Trivial , QEMU Developers On 9 February 2016 at 14:37, Paolo Bonzini wrote: > > > On 09/02/2016 15:28, Peter Maydell wrote: >> On 9 February 2016 at 14:21, Daniel P. Berrange wrote: >>> > On Tue, Feb 09, 2016 at 03:16:57PM +0100, Paolo Bonzini wrote: >>> > include/qemu/sockets.h also has windows.h included before winsock2.h >>> > >>> > Presumably it didn't cause a failure for you because everything using >>> > sockets.h already pulls in osdep.h. A reason to prune sockets.h >>> > headers perhaps. >> More generally we could prune anything including windows.h manually >> (there are a dozen or so .c and .h files doing that currently). > > I honestly do not have time to work on this. :( That's OK, I currently have a bunch of include file cleanups going through so one more won't hurt too much :-) -- PMM