From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
"Marcin Chojnacki" <marcinch7@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand()
Date: Fri, 17 Feb 2017 14:11:12 +0000 [thread overview]
Message-ID: <CAFEAcA8g6H5rHSc=bLOjx2tn+=WDSvevnPc3LokMUDuarqxZPg@mail.gmail.com> (raw)
In-Reply-To: <20170217140505.GB11399@redhat.com>
On 17 February 2017 at 14:05, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Fri, Feb 17, 2017 at 12:22:39PM +0000, Peter Maydell wrote:
>> We should probably improve crypto/random-platform.c to use
>> getentropy() if available, which would fix the "BSD or OSX
>> host and not using gcrypt or gnutls" case which I think is
>> the most likely cause of qcrypto_random_bytes() failing.
>
> randopm-platform.c currentl uses /dev/urandom or /dev/random,
> so that should work when GNUTLS/gcrypt are both disabled at
> build time.
Ah, and OSX and the BSDs have those devices. (I had
mistakenly assumed they were a linuxism.)
> What would fail, is uses it from a chroot with an empty /dev
> of course.
Yes; replacing the rand() in linux-user/main.c would require
this I think (unless we're willing to fall back to rand ;-))
thanks
-- PMM
prev parent reply other threads:[~2017-02-17 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 12:22 [Qemu-devel] [PATCH] bcm2835_rng: Use qcrypto_random_bytes() rather than rand() Peter Maydell
2017-02-17 14:05 ` Daniel P. Berrange
2017-02-17 14:11 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8g6H5rHSc=bLOjx2tn+=WDSvevnPc3LokMUDuarqxZPg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=marcinch7@gmail.com \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.