All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: "Andrew Jones" <drjones@redhat.com>,
	"Jose Marinho" <Jose.Marinho@arm.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	tf-a@lists.trustedfirmware.org, qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down
Date: Fri, 22 Jan 2021 15:47:01 +0000	[thread overview]
Message-ID: <CAFEAcA8gGHP0eFmkxu=rV6RqR=g65uPQvZf7utWLTGLp-V8A7A@mail.gmail.com> (raw)
In-Reply-To: <20210120092748.14789-4-maxim.uvarov@linaro.org>

On Wed, 20 Jan 2021 at 09:27, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> Add secure pl061 for reset/power down machine from
> the secure world (Arm Trusted Firmware). Connect it
> with gpio-pwr driver.
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

A nit, which I raise only because you'll need a respin anyway:


> +    /* connect secure pl061 to gpio-pwr */
> +    qdev_connect_gpio_out(pl061_dev, SECURE_GPIO_REBOOT,
> +                          qdev_get_gpio_in_named(gpio_pwr_dev, "reset", 0));

> +    qemu_fdt_add_subnode(vms->fdt, "/gpio-restart");

We have three different names for the same thing here: 'reboot',
'reset' and 'restart'. If we name the GPIO line SECURE_GPIO_RESET
we can at least get that down to two.

thanks
-- PMM


      parent reply	other threads:[~2021-01-22 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  9:27 [PATCHv8 0/3] arm-virt: add secure pl061 for reset/power down Maxim Uvarov
2021-01-20  9:27 ` [PATCHv8 1/3] hw: gpio: implement gpio-pwr driver for qemu reset/poweroff Maxim Uvarov
2021-01-22 15:48   ` Peter Maydell
2021-01-20  9:27 ` [PATCHv8 2/3] arm-virt: refactor gpios creation Maxim Uvarov
2021-01-22  8:07   ` Andrew Jones
2021-01-20  9:27 ` [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down Maxim Uvarov
2021-01-22  8:29   ` Andrew Jones
2021-01-22 10:09     ` Peter Maydell
2021-01-22 10:17       ` Andrew Jones
2021-01-22 15:47   ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8gGHP0eFmkxu=rV6RqR=g65uPQvZf7utWLTGLp-V8A7A@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=Jose.Marinho@arm.com \
    --cc=drjones@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=maxim.uvarov@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tf-a@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.