From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30D4CA9EB5 for ; Mon, 21 Oct 2019 09:43:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D43A2089C for ; Mon, 21 Oct 2019 09:43:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x7UBR0Wu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D43A2089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUDj-0000SZ-Eh for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 05:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36897) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMU9n-0004k1-Tb for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMU9m-0000Aq-Qh for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:39:19 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:39553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMU9m-00008X-AC for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:39:18 -0400 Received: by mail-ot1-x344.google.com with SMTP id s22so10403407otr.6 for ; Mon, 21 Oct 2019 02:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MtHnke2bzns6MDeKr83foHZX1HR+Uo5i8lrNykscWLo=; b=x7UBR0Wu+o7Obcts6e3og/3YhlVdIChRP/0n1lJN4/hkfCoKHczbBk91e7PCzc8Mbp w/emH/xMqZvByceXTZMNMNV9EuL3k0W6asvsX0IzZCeJ7brTHAwLbxtsosLhsWDYbAD8 PuASEAQYchwdNc5ihq9OE/Djk1zWhh2A+DrDoGkNbO/xGJQMkTXcA1V1/U0B7TA1NcUp gPlShpGNGHA6aVeW8kJbhQPY3xAWsuRYUTL0OLM1ayJHYB7HW+WFEKvqboAKDg320t6x iJKS/w/LfWRTjKaveaSOkeVnblRTxjmuno7zQnCKqOxGH41tPGwNw0tOYG/2b46nN96a r/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MtHnke2bzns6MDeKr83foHZX1HR+Uo5i8lrNykscWLo=; b=idWGJk0ZZvqHEeyVGwdty5hJha5CCVHJ4Kn9oGNCLS4A0p+CRYueVABlUvrE8qU8WW U73sazoTZ4v0fqgT0LWfhQkBCdYmY/oMI8uT4/MsFTfksmU3KFia94jmOHQvvsDkIKD2 X6o/QShqUO+4MrYd5Jrqaf3fbD3SNOAHfP1glrhxycg6zw/bj+fHL6xJWp0dy9x7EkRZ xjW5Cm/ggsG9wWOttzQJPwisUjA+SAemcLoVG15dLn+QEpmAFwzkv/rlKT1zy0URVBO8 nVAw/sAc2Ie75Mu4k9Y9TGwFsBua8/YIzvvJ7EY4e35eEep8BWZ9PMg4kkloOoa09YJ4 ZVSQ== X-Gm-Message-State: APjAAAX+fSJCJb/MGj7EdglGjxsLaKsaGlVAZHaqoYF9P0JAkIYQudDP DstqAB5n418kyjCBlyXJpoXfp0h4SGosmKpVGACFZQ== X-Google-Smtp-Source: APXvYqw7uwp6+Xd5H4pb0Q+y8R92zR985sbQmILVjM3Yq1Bz8dYQxMu36jMzMjhLyQdKTUBI/CrCNI89J4kxID8syLQ= X-Received: by 2002:a05:6830:ca:: with SMTP id x10mr16984090oto.221.1571650757149; Mon, 21 Oct 2019 02:39:17 -0700 (PDT) MIME-Version: 1.0 References: <20191020225650.3671-1-philmd@redhat.com> <20191020225650.3671-13-philmd@redhat.com> <42944bea-4b15-7bdf-61a7-f1c73f5f7c2b@redhat.com> In-Reply-To: <42944bea-4b15-7bdf-61a7-f1c73f5f7c2b@redhat.com> From: Peter Maydell Date: Mon, 21 Oct 2019 10:39:06 +0100 Message-ID: Subject: Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , "Michael S. Tsirkin" , Leif Lindholm , Mark Cave-Ayland , QEMU Developers , KONRAD Frederic , Paolo Bonzini , "Edgar E. Iglesias" , Rob Herring , Andrey Smirnov , Helge Deller , Markus Armbruster , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Joel Stanley , Aleksandar Rikalo , Richard Henderson , Artyom Tarasenko , Antony Pavlov , Eduardo Habkost , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-arm , Jan Kiszka , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Igor Mammedov , David Gibson , Radoslaw Biernacki , Thomas Huth , Andrew Baumann , Jean-Christophe Dubois , Andrew Jeffery , Michael Walle , qemu-ppc , Aleksandar Markovic , Peter Chubb , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 21 Oct 2019 at 10:34, Philippe Mathieu-Daud=C3=A9 wrote: > > On 10/21/19 11:22 AM, Peter Maydell wrote: > > On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daud=C3=A9 wrote: > >> > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > > > >> hw/arm/virt.c | 2 +- > > > > I think from a quick code scan that this is ok, but did > > you test that migration compat from old to new still works? > > I vaguely recall that there are some cases when adding an > > owner to a memory region changes the name string used for > > identifying the ramblock in migration. > > It seems to still works: > > $ make check-qtest-aarch64 V=3D1 > This test migrate the virt machine. > > Is this enough? No, you need to test migration from a QEMU binary without this patchset to a QEMU binary that has it. Otherwise you're only checking that the new version can migrate from itself to itself. I find the easiest way to test this is just to use the 'savevm' command to save a state snapshot to a qcow2 disk image while running the old binary, and then run 'loadvm' with the new binary and check it restored OK. thanks -- PMM