From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, Chad Joan <chadjoan@gmail.com>,
Fam Zheng <famz@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.
Date: Tue, 21 Feb 2017 09:58:12 +0000 [thread overview]
Message-ID: <CAFEAcA8jC7swgVYN=pRhbFRD23t8eqrY5GuaLaO8MnUBKpLm5A@mail.gmail.com> (raw)
In-Reply-To: <87wpcjlw32.fsf@dusky.pond.sub.org>
On 21 February 2017 at 09:41, Markus Armbruster <armbru@redhat.com> wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> [...]
>> 'git send-email -s' can also add Signed-off-by: lines, if you didn't add
>> them earlier (but only if you use send-email, rather than attachments) :)
>
> That's fine, as you *should* use git send-email.
It has the disadvantage that checkpatch will complain at you
when you test your patches before sending them, because the
sign-off is missing... Personally I recommend adding the signoff
lines earlier in the process.
thanks
-- PMM
next prev parent reply other threads:[~2017-02-21 9:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:30 [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems Chad Joan
2017-02-16 16:58 ` Paolo Bonzini
2017-02-16 17:23 ` Laszlo Ersek
2017-02-16 17:47 ` Chad Joan
2017-02-17 6:43 ` Fam Zheng
2017-02-17 9:23 ` Laszlo Ersek
2017-02-17 10:11 ` Fam Zheng
2017-02-17 9:28 ` Peter Maydell
2017-02-17 15:34 ` Eric Blake
2017-02-17 16:54 ` Chad Joan
2017-02-17 16:56 ` Peter Maydell
2017-02-17 16:57 ` Paolo Bonzini
2017-02-17 17:07 ` Chad Joan
2017-02-17 17:15 ` Peter Maydell
2017-02-19 7:22 ` Chad Joan
2017-02-19 12:12 ` Peter Maydell
2017-02-21 2:53 ` Eric Blake
2017-02-17 17:17 ` Eric Blake
2017-02-19 7:02 ` Chad Joan
2017-02-21 3:02 ` Eric Blake
2017-02-21 9:41 ` Markus Armbruster
2017-02-21 9:58 ` Peter Maydell [this message]
2017-02-17 18:13 ` John Snow
2017-02-17 8:45 ` Paolo Bonzini
2017-02-17 8:56 ` Paolo Bonzini
2017-02-17 9:17 ` Laszlo Ersek
2017-02-17 11:11 ` Paolo Bonzini
2017-02-17 11:43 ` Chad Joan
2017-02-17 10:18 ` Peter Maydell
2017-02-17 11:20 ` Paolo Bonzini
2017-02-17 16:57 ` Peter Maydell
2017-04-06 18:15 ` Rainer Müller
2017-04-06 18:36 ` Peter Maydell
2017-06-02 13:58 ` Peter Maydell
2017-02-16 16:59 ` Eric Blake
2017-02-16 17:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8jC7swgVYN=pRhbFRD23t8eqrY5GuaLaO8MnUBKpLm5A@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=chadjoan@gmail.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.