From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bHoSs-0004YL-GS
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:33:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bHoSq-00050s-I3
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:33:49 -0400
Received: from mail-vk0-x22b.google.com ([2607:f8b0:400c:c05::22b]:35419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bHoSq-00050l-8u
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:33:48 -0400
Received: by mail-vk0-x22b.google.com with SMTP id j2so12464691vkg.2
	for <qemu-devel@nongnu.org>; Tue, 28 Jun 2016 01:33:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87d1n1ener.fsf@dusky.pond.sub.org>
References: <1466777957-5126-1-git-send-email-armbru@redhat.com>
	<1466777957-5126-3-git-send-email-armbru@redhat.com>
	<CAFEAcA-S+VBrmjoZx0KX2ngGVjiY_a+eFiM0O4tBEL7khVjxLg@mail.gmail.com>
	<87wplbb0mt.fsf@dusky.pond.sub.org>
	<CAFEAcA_WJ8zvJJW7gbKuJViR2Y0e30dqCnNH-hZZcvC0nm044w@mail.gmail.com>
	<87d1n1ener.fsf@dusky.pond.sub.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 28 Jun 2016 09:33:28 +0100
Message-ID: <CAFEAcA8kmy8Xw3cfPV-+6PsY3rHX4wCeom7YK4=e6V=gp+4J9g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 28 June 2016 at 09:19, Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On 27 June 2016 at 07:34, Markus Armbruster <armbru@redhat.com> wrote:
>>> Peter Maydell <peter.maydell@linaro.org> writes:
>>>> This is third-party code. We're not going to change it, so
>>>> we should avoid scanning it rather than adding tags which
>>>> will get lost next time we do an update to a new upstream
>>>> version...
>>>
>>> I can revive v1's blacklist for this directory.  Any others?
>>
>> The clean-includes blacklist is
>> XDIRREGEX='^(tests/tcg|tests/multiboot|pc-bios|disas/libvixl)'
>>
>> (which covers both 3rd-party imports and code which is intended to
>> be built standalone and so doesn't follow QEMU's include
>> rules.)
>
> Noted.
>
> What about linux-headers/ and include/standard-headers/?

Mmm, clean-includes skips include/standard-headers (as a case
in the switch statement, not via the blacklist regex). It
doesn't skip linux-headers, though arguably it should. I think
it just never complained about anything in linux-headers so
I didn't identify it as something that needed to be skipped :-)

thanks
-- PMM