From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731BAC4707F for ; Thu, 27 May 2021 10:56:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B5CF611CD for ; Thu, 27 May 2021 10:56:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B5CF611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmDgR-0001pg-39 for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 06:56:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmDWW-00056f-Lo for qemu-devel@nongnu.org; Thu, 27 May 2021 06:45:57 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:43786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmDWT-0007hl-Gn for qemu-devel@nongnu.org; Thu, 27 May 2021 06:45:55 -0400 Received: by mail-ed1-x52f.google.com with SMTP id s6so279653edu.10 for ; Thu, 27 May 2021 03:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CR8hUhEBdJ60hmdhochqHz6Yl1u78molGc7Hdjcll1U=; b=z03M78oazbXOfknAllMky+MqB6dhEcPw5ZCzWpOwagRWSM6BTGg8CGyUQjPii16VLt DirHgOcAumFZRqhYd9eL56A0r2+fTNqQEJRT+dwtoH8xG34o5BW3mgnzIrXTAKZXv4ik HQSO7UByuOQALiRGadk8Aa2WEQ4qKOy+8hBNXylyBXKmmeDVBmF4QOR0PVG7KBxuYJ54 pJUt2/Z9Xm7nZFuEY25JPIwTCIPMkiKm9OqXSIbN9MOwV9OSn7aAyMvPUrxKOoC5VV8D WmCxfgRQ4QcAJkOUl+wk28t2ECZX+ei8CLZ1uXNZLNcIo9NMozxue/VATWS5r1eP+4Nu BYzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CR8hUhEBdJ60hmdhochqHz6Yl1u78molGc7Hdjcll1U=; b=be0AIYoo9nkhQO+kIKx7zW9R8Um850ItaC6GeFYljktEQRfzy2ux2CAQ5XGOMmHj7C dXaxE6jqq6LZoeGyhYpppI1zWpkRPI+6SB0klyRAcsyZRYAZtrRp/Xc1bXCp6WkZJfAH Yggk3wljDvX3FHO1uNqBhGnugSws6ktoPHzO3ZwobPa9uNutXdm/d6RvzZFuDXHv1+MG A2B2jjJHChuKvjkohInYr/S7mEU04fTYwxYRAcvo67KGvBklPqgRh6sHm244tysjYwAd kD3XfHUVNq+uqb0UEk/p3uaQGCMqeN6JSdoMKYLLmrMDM1UUCQDqQlxCbwnxkOAHKPJC ouQA== X-Gm-Message-State: AOAM533dPldGuy7uuyPqfLS9xBJyolVyqTVW/8xpTDT0sjnpHhxOEaXQ qM3N2aWh/5qsfytEU4bWMv+k7CUAXA4etikhU41sfw== X-Google-Smtp-Source: ABdhPJwf9SMJdCaAkpBd0ElUFNZiq8K/PUM4igRSt2qz8+FRoS7yOL62OPRFf1IilqVsNDKqpYD8k9PWSdv9U/CfSY4= X-Received: by 2002:a05:6402:19a:: with SMTP id r26mr3387468edv.44.1622112351801; Thu, 27 May 2021 03:45:51 -0700 (PDT) MIME-Version: 1.0 References: <20210524024655.11115-1-someguy@effective-light.com> In-Reply-To: From: Peter Maydell Date: Thu, 27 May 2021 11:45:26 +0100 Message-ID: Subject: Re: [PATCH] linux-user: make process_pending_signals thread-safe To: Hamza Mahfooz Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Laurent Vivier , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 May 2021 at 11:37, Hamza Mahfooz wrote: > > > > On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell > wrote: > > If we do want to change from sigprocmask() to pthread_sigmask(), we > > should be consistent about doing that, not just change this call > > only.) > On that note, do you think it would worthwhile to have a Coccinelle > script replace all instances of sigprocmask with pthread_sigmask (in > linux-user, of course)? What issue are we trying to fix by making this change ? There are only 7 calls so a coccinelle script seems like overkill. thanks -- PMM