All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)
Date: Fri, 27 Jul 2018 18:19:34 +0100	[thread overview]
Message-ID: <CAFEAcA8pkdr7Rsh+XMNbWrFpue26LGeHL5KpD8X+djiSVjpbwg@mail.gmail.com> (raw)
In-Reply-To: <20180727155602.10148-1-armbru@redhat.com>

On 27 July 2018 at 16:55, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc:
>
>   Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27
>
> for you to fetch changes up to 307fb894ce0608aede990ec40ce84eaeb358c8ec:
>
>   qstring: Move qstring_from_substr()'s @end one to the right (2018-07-27 17:16:03 +0200)
>
> ----------------------------------------------------------------
> QObject patches for 2018-07-27 (3.0.0-rc3)
>
> This pull request fixes an integer overflow bug, and hardens the code
> in question a bit.  Abuse of QMP can make the bug crash QEMU, so it
> seems worth fixing at this late stage.
>
> ----------------------------------------------------------------
> Markus Armbruster (2):
>       qstring: Assert size calculations don't overflow
>       qstring: Move qstring_from_substr()'s @end one to the right
>
> liujunjie (1):
>       qstring: Fix qstring_from_substr() not to provoke int overflow


Hi -- this passes my buildtests, but the commit from liujunjie
seems to be missing your maintainer signed-off-by (and possibly
a reviewed-by tag ?) Can I ask you to fix that up and resend,
please?

thanks
-- PMM

  parent reply	other threads:[~2018-07-27 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 15:55 [Qemu-devel] [PULL 0/3] QObject patches for 2018-07-27 (3.0.0-rc3) Markus Armbruster
2018-07-27 15:56 ` [Qemu-devel] [PULL 1/3] qstring: Fix qstring_from_substr() not to provoke int overflow Markus Armbruster
2018-07-27 15:56 ` [Qemu-devel] [PULL 2/3] qstring: Assert size calculations don't overflow Markus Armbruster
2018-07-27 15:56 ` [Qemu-devel] [PULL 3/3] qstring: Move qstring_from_substr()'s @end one to the right Markus Armbruster
2018-07-27 17:19 ` Peter Maydell [this message]
2018-07-28  7:16   ` [Qemu-devel] [PULL 0/3] QObject patches for 2018-07-27 (3.0.0-rc3) Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8pkdr7Rsh+XMNbWrFpue26LGeHL5KpD8X+djiSVjpbwg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.