All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	"Amithash Prasad" <amithash@fb.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Vijay Khemka" <vijaykhemka@fb.com>,
	"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v3] aspeed: Add support for the sonorapass-bmc board
Date: Mon, 11 May 2020 16:07:03 +0100	[thread overview]
Message-ID: <CAFEAcA8q7xdsyz+=c2iCqcLxDFSMq5f1tvP1OPuQxV4qLfJncg@mail.gmail.com> (raw)
In-Reply-To: <20200511131328.GF10214@heinlein>

On Mon, 11 May 2020 at 14:13, Patrick Williams <patrick@stwcx.xyz> wrote:
>
> On Mon, May 11, 2020 at 11:54:42AM +0100, Peter Maydell wrote:
> > On Wed, 6 May 2020 at 19:32, Patrick Williams <patrick@stwcx.xyz> wrote:
>
> > Looking up through the thread I can't find the email where
> > Amithash gave his reviewed-by tag -- did I miss it?
>
> I probably shouldn't have done this.  I asked Amithash off-list for his
> approval to add his Reviewed-by.  I'll ask him to reply to this with
> confirmation.

Thanks; no big deal. I figured I'd check because the details
of how we handle reviewed-by tags are a bit non-obvious if you
haven't worked with projects like QEMU or the kernel that use
this email-based workflow before.

> > PS: for the future, v2/v3 etc patches should be sent as
> > fresh emails, not as followups/replies to the v1.
>
> Thanks.  I missed this detail when I read [1] before but I see it now.
> It seems like LKML tends to do the opposite?

I don't do kernel development but AIUI they have the same
general approach we do. Their process doc:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n771
says:
  "for a multi-patch series, it is generally
   best to avoid using In-Reply-To: to link to older versions of the
   series.  This way multiple versions of the patch don't become an
   unmanageable forest of references in email clients."

thanks
-- PMM


  reply	other threads:[~2020-05-11 15:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 11:37 [PATCH] aspeed: Add support for the sonorapass-bmc board Patrick Williams
2020-05-01 15:26 ` no-reply
2020-05-04  6:43 ` Cédric Le Goater
2020-05-06 17:30 ` [PATCH v2] " Patrick Williams
2020-05-06 18:06   ` Amithash Prasad via
2020-05-06 18:28     ` Patrick Williams
2020-05-06 18:32   ` [PATCH v3] " Patrick Williams
2020-05-11 10:54     ` Peter Maydell
2020-05-11 13:13       ` Patrick Williams
2020-05-11 15:07         ` Peter Maydell [this message]
2020-05-14 11:05     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8q7xdsyz+=c2iCqcLxDFSMq5f1tvP1OPuQxV4qLfJncg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=amithash@fb.com \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=patrick@stwcx.xyz \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vijaykhemka@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.