From: Peter Maydell <peter.maydell@linaro.org>
To: Hao Wu <wuhaotsh@google.com>
Cc: Corey Minyard <minyard@acm.org>,
Titus Rwantare <titusr@google.com>,
Patrick Venture <venture@google.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Havard Skinnemoen <hskinnemoen@google.com>,
CS20 KFTing <kfting@nuvoton.com>, qemu-arm <qemu-arm@nongnu.org>,
IS20 Avi Fishman <Avi.Fishman@nuvoton.com>
Subject: Re: [PATCH 6/7] hw/arm: quanta-gbs-bmc add i2c devices
Date: Thu, 19 Aug 2021 14:55:52 +0100 [thread overview]
Message-ID: <CAFEAcA8s4dW3rh+-5Cd9k4tTNRhUqvTaLpprenermJSFUM0mKQ@mail.gmail.com> (raw)
In-Reply-To: <20210813233353.2099459-7-wuhaotsh@google.com>
On Sat, 14 Aug 2021 at 00:34, Hao Wu <wuhaotsh@google.com> wrote:
>
> From: Patrick Venture <venture@google.com>
>
> Adds supported i2c devices to the quanta-gbc-bmc board.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> ---
> hw/arm/npcm7xx_boards.c | 79 +++++++++++++++++++++++------------------
> 1 file changed, 45 insertions(+), 34 deletions(-)
>
Does the documentation need updating to mention these newly supported devices ?
> static void quanta_gbs_i2c_init(NPCM7xxState *soc)
> {
> - /*
> - * i2c-0:
> - * pca9546@71
> - *
> - * i2c-1:
> + I2CSlave *i2c_mux;
> +
> + /* i2c-0: */
> + i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 0), TYPE_PCA9546, 0x71);
> +
> + /* i2c-1:
> * pca9535@24
> * pca9535@20
> * pca9535@21
This leaves this multiline block comment with the wrong format: QEMU's
coding style wants the leading "/*" on a line of its own. Similarly
for some others in this patch.
thanks
-- PMM
next prev parent reply other threads:[~2021-08-19 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 23:33 [PATCH 0/7] Misc NPCM7XX patches Hao Wu
2021-08-13 23:33 ` [PATCH 1/7] hw/i2c: Clear ACK bit in NPCM7xx SMBus module Hao Wu
2021-08-13 23:33 ` [PATCH 2/7] hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBus Hao Wu
2021-08-13 23:33 ` [PATCH 3/7] hw/adc: Fix CONV bit in NPCM7XX ADC CON register Hao Wu
2021-08-13 23:33 ` [PATCH 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC Hao Wu
2021-08-20 7:28 ` Philippe Mathieu-Daudé
2021-08-13 23:33 ` [PATCH 5/7] hw/nvram: Add a new auxiliary function to init at24c eeprom Hao Wu
2021-08-19 13:59 ` Peter Maydell
2021-08-13 23:33 ` [PATCH 6/7] hw/arm: quanta-gbs-bmc add i2c devices Hao Wu
2021-08-19 13:55 ` Peter Maydell [this message]
2021-08-13 23:33 ` [PATCH 7/7] hw/arm: Use unit number in quanta-gsj eeprom files Hao Wu
2021-08-19 14:00 ` [PATCH 0/7] Misc NPCM7XX patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8s4dW3rh+-5Cd9k4tTNRhUqvTaLpprenermJSFUM0mKQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Avi.Fishman@nuvoton.com \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=minyard@acm.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.