Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags

From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Andrew Jones" <drjones@redhat.com>,
	"Patch Tracking" <patches@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Greg Bellows" <greg.bellows@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags
Date: Tue, 27 Jan 2015 19:30:42 +0000	[thread overview]
Message-ID: <CAFEAcA8sFNZuO+K32g1XcaCJSKUCv0MKv=eKgccC+jz=uWfRkg@mail.gmail.com> (raw)
In-Reply-To: <1422037228-5363-5-git-send-email-peter.maydell@linaro.org>

On 23 January 2015 at 18:20, Peter Maydell <peter.maydell@linaro.org> wrote:
> +/* Determine the current mmu_idx to use for normal loads/stores */
>  static inline int cpu_mmu_index (CPUARMState *env)
>  {
> -    return arm_current_el(env);
> +    int el = arm_current_el(env);
> +
> +    if (el < 3 && arm_is_secure_below_el3(env)) {
> +        return ARMMMUIdx_S1SE0 + el;
> +    }
> +    return el;
>  }

Just noticed the stray extra space between function name and '('
here; will delete the space in v2, since we're rewriting the whole
function body anyhow...

-- PMM