From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] xen-block: stop leaking memory in
 xen_block_drive_create()
Date: Tue, 19 Feb 2019 16:37:20 +0000
Message-ID: <CAFEAcA8tv=3isnJLfJx2a4TiEZR9rHzwqj+p=fB_94rJw=k54A__38964.7140794963$1550594305$gmane$org@mail.gmail.com>
References: <20190219163440.15702-1-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6])
 by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from
 <SRS0=QmS2=Q2=linaro.org=peter.maydell@srs-us1.protection.inumbo.net>)
 id 1gw8Oi-0000Ux-Uq
 for xen-devel@lists.xenproject.org; Tue, 19 Feb 2019 16:37:33 +0000
Received: by mail-ot1-x341.google.com with SMTP id t7so18819475otk.8
 for <xen-devel@lists.xenproject.org>; Tue, 19 Feb 2019 08:37:31 -0800 (PST)
In-Reply-To: <20190219163440.15702-1-paul.durrant@citrix.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Paul Durrant <paul.durrant@citrix.com>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, "open list:X86" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

SGkgUGF1bCAtLSB5b3UgdHlwb2VkIHRoZSBxZW11LWRldmVsIGxpc3QgZW1haWwgYWRkcmVzczsg
Y2MnZCB0aGUgcmlnaHQgb25lLgoKdGhhbmtzCi0tIFBNTQoKT24gVHVlLCAxOSBGZWIgMjAxOSBh
dCAxNjozNSwgUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4K
PiBUaGUgbG9jYWxseSBhbGxvY2F0ZWQgUURpY3QtcyBuZWVkIHRvIGJlIGZyZWVkLiAoJ2ZpbGVf
bGF5ZXInIHdpbGwgYmUKPiBmcmVlZCBpbXBsaWNpdGx5IHNpbmNlIGl0IGlzIGFkZGVkIGFzIGFu
IG9iamVjdCB0byAnZHJpdmVyX2xheWVyJykuCj4KPiBTcG90dGVkIGJ5IENvdmVyaXR5OiBDSUQg
MTM5ODY0OQo+Cj4gV2hpbGUgaW4gdGhlIG5laWdoYm91cmhvb2QgZnJlZSAnZHJpdmVyJyBhbmQg
J2ZpbGVuYW1lJyBhcyBzb29uIGFzIHRoZXkgYXJlCj4gYWRkZWQgdG8gdGhlIFFEaWN0cy4gRnJl
ZWluZyBhZnRlciB0aGUgJ2RvbmUnIGxhYmVsIGRvZXNuJ3QgbWFrZSB0aGF0IG11Y2gKPiBzZW5z
ZSBhcywgaWYgdGhlIGVycm9yIHBhdGgganVtcHMgdG8gdGhhdCBsYWJlbCwgdGhlIHZhbHVlcyB3
b3VsZCBiZSBOVUxMCj4gYW55d2F5Lgo+Cj4gVGhpcyBwYXRjaCBhbHNvIG1ha2VzIHRoYXQgbW9y
ZSBvYnZpb3VzIGJ5IHRha2luZyB0aGUgZXJyb3IgcGF0aCBpZgo+ICdwYXJhbXMnIGlzIE5VTEwg
YW5kIHRoZW4gYXNzZXJ0aW5nIHRoYXQgYm90aCBkcml2ZXIgYW5kIGZpbGVuYW1lIGFyZQo+IG5v
bi1OVUxMIGluIHRoZSBub3JtYWwgcGF0aC4KPgo+IFJlcG9ydGVkLWJ5OiBQZXRlciBNYXlkZWxs
IDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50
IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiAtLS0KPiBDYzogU3RlZmFubyBTdGFiZWxsaW5p
IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENjOiBBbnRob255IFBlcmFyZCA8YW50aG9ueS5w
ZXJhcmRAY2l0cml4LmNvbT4KPiBDYzogS2V2aW4gV29sZiA8a3dvbGZAcmVkaGF0LmNvbT4KPiBD
YzogTWF4IFJlaXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4KPiAtLS0KPiAgaHcvYmxvY2sveGVuLWJs
b2NrLmMgfCAxNiArKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlv
bnMoKyksIDcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvaHcvYmxvY2sveGVuLWJsb2Nr
LmMgYi9ody9ibG9jay94ZW4tYmxvY2suYwo+IGluZGV4IDM3YTQ1NmMyMDcuLjcwZmMyNDU1ZTgg
MTAwNjQ0Cj4gLS0tIGEvaHcvYmxvY2sveGVuLWJsb2NrLmMKPiArKysgYi9ody9ibG9jay94ZW4t
YmxvY2suYwo+IEBAIC03NDMsMTIgKzc0MywxMiBAQCBzdGF0aWMgWGVuQmxvY2tEcml2ZSAqeGVu
X2Jsb2NrX2RyaXZlX2NyZWF0ZShjb25zdCBjaGFyICppZCwKPiAgICAgICAgICB9Cj4KPiAgICAg
ICAgICBnX3N0cmZyZWV2KHYpOwo+IC0gICAgfQo+IC0KPiAtICAgIGlmICghZmlsZW5hbWUpIHsK
PiAtICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJubyBmaWxlbmFtZSIpOwo+ICsgICAgfSBlbHNl
IHsKPiArICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJubyBwYXJhbXMiKTsKPiAgICAgICAgICBn
b3RvIGRvbmU7Cj4gICAgICB9Cj4gKwo+ICsgICAgYXNzZXJ0KGZpbGVuYW1lKTsKPiAgICAgIGFz
c2VydChkcml2ZXIpOwo+Cj4gICAgICBkcml2ZSA9IGdfbmV3MChYZW5CbG9ja0RyaXZlLCAxKTsK
PiBAQCAtNzU4LDYgKzc1OCw3IEBAIHN0YXRpYyBYZW5CbG9ja0RyaXZlICp4ZW5fYmxvY2tfZHJp
dmVfY3JlYXRlKGNvbnN0IGNoYXIgKmlkLAo+Cj4gICAgICBxZGljdF9wdXRfc3RyKGZpbGVfbGF5
ZXIsICJkcml2ZXIiLCAiZmlsZSIpOwo+ICAgICAgcWRpY3RfcHV0X3N0cihmaWxlX2xheWVyLCAi
ZmlsZW5hbWUiLCBmaWxlbmFtZSk7Cj4gKyAgICBnX2ZyZWUoZmlsZW5hbWUpOwo+Cj4gICAgICBp
ZiAobW9kZSAmJiAqbW9kZSAhPSAndycpIHsKPiAgICAgICAgICBxZGljdF9wdXRfYm9vbChmaWxl
X2xheWVyLCAicmVhZC1vbmx5IiwgdHJ1ZSk7Cj4gQEAgLTc5MywxNiArNzk0LDE3IEBAIHN0YXRp
YyBYZW5CbG9ja0RyaXZlICp4ZW5fYmxvY2tfZHJpdmVfY3JlYXRlKGNvbnN0IGNoYXIgKmlkLAo+
ICAgICAgZHJpdmVyX2xheWVyID0gcWRpY3RfbmV3KCk7Cj4KPiAgICAgIHFkaWN0X3B1dF9zdHIo
ZHJpdmVyX2xheWVyLCAiZHJpdmVyIiwgZHJpdmVyKTsKPiArICAgIGdfZnJlZShkcml2ZXIpOwo+
ICsKPiAgICAgIHFkaWN0X3B1dF9vYmooZHJpdmVyX2xheWVyLCAiZmlsZSIsIFFPQkpFQ1QoZmls
ZV9sYXllcikpOwo+Cj4gICAgICBnX2Fzc2VydCghZHJpdmUtPm5vZGVfbmFtZSk7Cj4gICAgICBk
cml2ZS0+bm9kZV9uYW1lID0geGVuX2Jsb2NrX2Jsb2NrZGV2X2FkZChkcml2ZS0+aWQsIGRyaXZl
cl9sYXllciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICZsb2NhbF9lcnIpOwo+Cj4gLWRvbmU6Cj4gLSAgICBnX2ZyZWUoZHJpdmVyKTsKPiAtICAgIGdf
ZnJlZShmaWxlbmFtZSk7Cj4gKyAgICBxb2JqZWN0X3VucmVmKGRyaXZlcl9sYXllcik7Cj4KPiAr
ZG9uZToKPiAgICAgIGlmIChsb2NhbF9lcnIpIHsKPiAgICAgICAgICBlcnJvcl9wcm9wYWdhdGUo
ZXJycCwgbG9jYWxfZXJyKTsKPiAgICAgICAgICB4ZW5fYmxvY2tfZHJpdmVfZGVzdHJveShkcml2
ZSwgTlVMTCk7Cj4gLS0KPiAyLjIwLjEuMi5nYjIxZWJiNgoKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2
ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls
bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==