From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQNKF-0001oi-7R for qemu-devel@nongnu.org; Mon, 22 Oct 2012 15:06:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQNKD-0001MW-Rs for qemu-devel@nongnu.org; Mon, 22 Oct 2012 15:06:11 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:44081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQNKD-0001MN-NE for qemu-devel@nongnu.org; Mon, 22 Oct 2012 15:06:09 -0400 Received: by mail-ie0-f173.google.com with SMTP id 17so4205207iea.4 for ; Mon, 22 Oct 2012 12:06:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <194bc92fae8a539ef01da90bf4dafe573d34468e.1350889929.git.peter.crosthwaite@xilinx.com> References: <194bc92fae8a539ef01da90bf4dafe573d34468e.1350889929.git.peter.crosthwaite@xilinx.com> Date: Mon, 22 Oct 2012 20:06:08 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 5/6] xilinx_zynq: add pl353 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: vineshp@xilinx.com, Anthony Liguori , qemu-devel@nongnu.org, john.williams@xilinx.com, pbonzini@redhat.com, edgar.iglesias@gmail.com On 22 October 2012 08:19, Peter Crosthwaite wrote: > + /* pl353 */ > + dev = qdev_create(NULL, "arm.pl35x"); > + /* FIXME: handle this somewhere central */ > + object_property_add_child(container_get(qdev_get_machine(), "/unattached"), > + "pl353", OBJECT(dev), NULL); Spoke briefly to Anthony on IRC about this and he said he didn't think it was necessary (though it might have been in the past). -- PMM