All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Cc: G 3 <programmingkidx@gmail.com>,
	Sandipan Das <sandipandas1990@gmail.com>,
	"qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>,
	aNikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions
Date: Tue, 30 May 2017 13:01:54 +0100	[thread overview]
Message-ID: <CAFEAcA8wCfDuSbs-+o-D8Sogrfda_U6kSCH0x5SrAGfAiknYyQ@mail.gmail.com> (raw)
In-Reply-To: <20170525200537.GA12666@pacoca>

On 25 May 2017 at 21:05,  <joserz@linux.vnet.ibm.com> wrote:
> What do you think about sharing the same ppc64.risu file to ppc
> and ppc64/ppc64le. Then, instead of:
>
> <NAME> PPC64LE 01111...
>
> we'd have:
>
> <NAME> PPC 01111...
>
> So, specific instructions would be:
>
> <NAME> PPC64LE 01111...
> <NAME> PPC64 01111...
> <NAME> PPC32 01111...
>
> It will allow users to select the arch by using patterns like: ./risugen
> --pattern "PPC64*", or --pattern "PPC32*".

I think we should aim to share the files, but that we should
have a better mechanism than just a convention on the pattern
name (which is easy to make mistakes with and also makes it
harder to use the --pattern argument for the purpose it was
intended for, since you have to combine your desired pattern
with the pattern to select the right bit of the instruction set).
This isn't limited to PPC either -- for ARM we'd like to be
able to mark instructions as ARMv7/ARMv8/present in some
optional instruction set extension, etc.

We could perhaps do that with an optional field in the
lines in the risu file to mark what part of the instruction
set they're in, and a command line argument to select the
instruction set variant(s) desired.

Another possible approach would be to have the PPC32 insns
in their own file, and some sort of #include directive to
pull them into the PPC64 file.

This is all "adding extra features to risu", though, so I
don't insist it be done.

thanks
-- PMM

  parent reply	other threads:[~2017-05-30 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.73115.1495441935.22737.qemu-devel@nongnu.org>
2017-05-22 13:06 ` [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions G 3
2017-05-23  6:17   ` Nikunj A Dadhania
2017-05-24  2:33     ` joserz
2017-05-25 20:05       ` joserz
2017-05-25 23:17         ` Programmingkid
2017-05-30 12:01         ` Peter Maydell [this message]
2017-05-30 14:21           ` G 3
2017-05-22  6:16 Sandipan Das
2017-05-22  7:03 ` Nikunj A Dadhania
2017-05-22  7:27   ` Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8wCfDuSbs-+o-D8Sogrfda_U6kSCH0x5SrAGfAiknYyQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=joserz@linux.vnet.ibm.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sandipandas1990@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.