From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF12C433E0 for ; Fri, 10 Jul 2020 15:55:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88A9A20720 for ; Fri, 10 Jul 2020 15:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kdqpCd8p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88A9A20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtvN6-0007s5-SA for qemu-devel@archiver.kernel.org; Fri, 10 Jul 2020 11:55:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtvIc-0002wW-Dl for qemu-devel@nongnu.org; Fri, 10 Jul 2020 11:50:54 -0400 Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]:33083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtvIW-0000bE-7l for qemu-devel@nongnu.org; Fri, 10 Jul 2020 11:50:54 -0400 Received: by mail-oo1-xc44.google.com with SMTP id d125so1084484oob.0 for ; Fri, 10 Jul 2020 08:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8mEhu8veV3Gnf9WIN+SjyxzLBHgb7ONc/B1MVOgnFH8=; b=kdqpCd8pmaytLDjuxWHuXXjFm1lUjjxv0wTFqdsCEY1jhZqwN9Y0yoOwbgzgWFrKdb 4AzQ9Bf9VPsMqP/+5OvHeKN2U36vh/MxUQ25E+sOtNSoiTq1CZbR2PJWUDJQkehu53ix JWFbEJo+u28qOj27MYzzKhZ5dKWurYamdaZuHVpXmYgo8I5/LYB9uTQ+JVdmm34VPRMp gK+vupFJB6TkLo5Wr/0E33XWFxo+T0qbJ3QGdmMiiNnIVEJQbDjsHqsWJPhWob7qHk/D w8WA48BdiU3HoGPrU79vmssn9Q6fBK+ODI2H2Ho59iAMI6X/tha0GwjPEUFGWaTVSOWU 6yTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8mEhu8veV3Gnf9WIN+SjyxzLBHgb7ONc/B1MVOgnFH8=; b=IsIo3cmkhjTUIp3eNWfU4hyXRVOI3OFDEhoIjW0lnzwpSD8kIaseHHbV1Okz7Oxt3J Zx5fuAWNZy9TpaRbGf8wQSMSX0iKRM9OmMq9OVhsvTJqEzZVlAzKFfZYYR0Krwll/LCN EDhpOhVmgxDzeLqOM/n23Brr/ZYoBNt2deEY9JTWjdERdFWHs4dCIepnkXf2UecGAYO6 pgwYb0ewKMmvtAPnYelr9DYWOXtHqvgiyrtH8fuK3uD4ZwdOaaslQH2N1LbkmyVgiE3+ S6+ZF/Y66cjkwcfGPOqiJA+9DVXH37vAeFFU66r1aELEgldO8+cku0Fwi1GsY+uOSOYE eTPA== X-Gm-Message-State: AOAM531XwlEHu8jAbIZnOjP/VXDGzDVY5aWKcdhfaYyMmZIPflPIDzjh HC1579q4D7dvYw2L4NP51im4fd22k+UQMZI26rcHRg== X-Google-Smtp-Source: ABdhPJyFq9PrtR89HStX4qxDsSJFNPrs+ED3KuyHZri2G/y/0oQTlCE+NsipV9FI6t3hUERhAmRstuJbwQ9Hzpvcm3g= X-Received: by 2002:a4a:2f15:: with SMTP id p21mr59592290oop.20.1594396246853; Fri, 10 Jul 2020 08:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20200708172542.25012-1-pbonzini@redhat.com> <9631042d-00e4-2a2e-292b-66ca1b590120@suse.de> <40f4c566-8a5b-c27e-22a7-2a112a0cd77d@suse.de> <2ea3943d-fc5b-4d75-deb2-06723da2ac74@redhat.com> In-Reply-To: <2ea3943d-fc5b-4d75-deb2-06723da2ac74@redhat.com> From: Peter Maydell Date: Fri, 10 Jul 2020 16:50:35 +0100 Message-ID: Subject: Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze To: Max Reitz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::c44; envelope-from=peter.maydell@linaro.org; helo=mail-oo1-xc44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Claudio Fontana , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 10 Jul 2020 at 16:46, Max Reitz wrote: > > On 10.07.20 17:42, Peter Maydell wrote: > > On Fri, 10 Jul 2020 at 16:31, Max Reitz wrote: > >> > >> On 10.07.20 17:18, Peter Maydell wrote: > >>> readarray only arrived sometime in bash 4, and the OSX system > >>> bash is 3.2.57, so it won't have that builtin. > >> > >> It arrived with 4.0, actually, which was released 11 years ago. > >> I had assumed that would be sufficiently mature. > >> > >> So, um, 11 years isn=E2=80=99t sufficiently mature then and I=E2=80=99= ll have to work > >> around not having readarray for macOS? > > > > It's the usual Apple-vs-GPL3 issue. > > > > I note that the iotests do seem to regularly run into > > non-portable constructs: Kevin's latest pullreq has > > just failed due to a use of 'truncate' that doesn't > > work on the BSDs. > > :/ > > I=E2=80=99ll send a patch to drop readarray. Thanks. I realised as a result of discussion on IRC that this slipped through my testing because my OSX system wasn't running iotests at all because it didn't have a GNU sed available. As Dan says, the other option is to do the same thing we do for GNU sed, and skip all the iotests if we don't have a new enough bash. I can always install sed and bash out of homebrew to bring my setup into line with the cirrus CI one. If we take that path we should update the cirrus CI config to make sure it also installs homebrew bash (and that the iotests use bash-from-the-path, not /bin/bash.) -- PMM