From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WwRTI-0005Zt-Su
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 03:36:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WwRTD-0000AQ-FP
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 03:36:52 -0400
Received: from mail-lb0-f176.google.com ([209.85.217.176]:45642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WwRTD-0000AJ-9P
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 03:36:47 -0400
Received: by mail-lb0-f176.google.com with SMTP id w7so870570lbi.7
	for <qemu-devel@nongnu.org>; Mon, 16 Jun 2014 00:36:46 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1402865252-25671-2-git-send-email-sbruno@freebsd.org>
References: <1402865252-25671-1-git-send-email-sbruno@freebsd.org>
	<1402865252-25671-2-git-send-email-sbruno@freebsd.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 16 Jun 2014 08:36:25 +0100
Message-ID: <CAFEAcA8zhYjm5zpRc8A+2ZrBQUBW8xeb3ch2OiP0WU7RhqjYRg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/3 v2] bsd-user: Revert part of update to
	rules.mk
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sean Bruno <sbruno@freebsd.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 15 June 2014 21:47, Sean Bruno <sbruno@freebsd.org> wrote:
> In c5cb1afc4675bf5ff66e7a149d2a8cffba2eaa9e rules.mk change was causing
> complete failure on bsd-user when not using --disable-curl
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
>  rules.mak | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/rules.mak b/rules.mak
> index dde8e00..4a33c27 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -22,7 +22,8 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>  # Same as -I$(SRC_PATH) -I., but for the nested source/object directories
>  QEMU_INCLUDES += -I$(<D) -I$(@D)
>
> -extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs))))
> +extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs))) \
> +                  $(foreach o,$(call expand-objs,$1),$($o-libs)))
>  expand-objs = $(strip $(sort $(filter %.o,$1)) \
>                    $(foreach o,$(filter %.mo,$1),$($o-objs)) \
>                    $(filter-out %.o %.mo,$1))

Fam, Paolo: looks like this extract-libs rune is stil causing
problems :-(

thanks
-- PMM