From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40717)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UbzGg-00036C-5j
	for qemu-devel@nongnu.org; Mon, 13 May 2013 16:22:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UbzGb-0006cW-JS
	for qemu-devel@nongnu.org; Mon, 13 May 2013 16:22:46 -0400
Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:53446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UbzGb-0006cS-CH
	for qemu-devel@nongnu.org; Mon, 13 May 2013 16:22:41 -0400
Received: by mail-la0-f50.google.com with SMTP id dz20so2737794lab.9
	for <qemu-devel@nongnu.org>; Mon, 13 May 2013 13:22:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4f3e255de05cb2779760c6559aba4b8c2bb09634.1368474222.git.mst@redhat.com>
References: <cover.1368474222.git.mst@redhat.com>
	<4f3e255de05cb2779760c6559aba4b8c2bb09634.1368474222.git.mst@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 13 May 2013 21:22:20 +0100
Message-ID: <CAFEAcA9+JjAboZnbQPMAr1aycj=Uc_6=qEzFHgEh=+N5rbZN0g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific
	bitopts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: seabios@seabios.org, lersek@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On 13 May 2013 21:00, Michael S. Tsirkin <mst@redhat.com> wrote:
> apic has its own version of bitops, with the
> difference that it works on u32 and not long.
> Add apic_ prefix to avoid namespace clashes.

Wouldn't it be better to consolidate so we only have
one set of bitops rather than a local set in this file?

thanks
-- PMM