All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: Juan Quintela <quintela@redhat.com>,
	qemu-devel@nongnu.org, andrew@openedhand.com, michael@walle.cc,
	paul@codesourcery.com, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage
Date: Fri, 15 Mar 2013 17:12:04 +0000	[thread overview]
Message-ID: <CAFEAcA90gvFxoVX9EUJCKghtUFp0eyy+9zfmsTXPtocySHLp_Q@mail.gmail.com> (raw)
In-Reply-To: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com>

On 10 March 2013 13:47, Igor Mitsyanko <i.mitsyanko@gmail.com> wrote:
> hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for dynamically
> allocated buffer migration, this was causing memory corruption.
> Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag set) instead.
>
> Not sure what to do with vmstate version for his devices, should I bump it? Migration
> was never working for them anyway.
>
> Only tested hw/sd.c, by saving/loading a snapshot of VM while it was playing videofile
> from SD card.

Cc'ing Juan in case he wants to comment on the vmstate changes.

-- PMM

  parent reply	other threads:[~2013-03-15 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10 13:47 [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage Igor Mitsyanko
2013-03-10 13:47 ` [Qemu-devel] [PATCH 1/3] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro Igor Mitsyanko
2013-03-10 13:47 ` [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf" Igor Mitsyanko
2013-03-18 18:33   ` Michael Walle
2013-03-10 13:47 ` [Qemu-devel] [PATCH 3/3] hw/onenand.c: fix migration of dynamically allocated buffer "otp" Igor Mitsyanko
2013-03-15 17:12 ` Peter Maydell [this message]
     [not found]   ` <51435829.5020106@gmail.com>
2013-03-15 17:23     ` [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage Igor Mitsyanko
2013-03-18 16:19 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA90gvFxoVX9EUJCKghtUFp0eyy+9zfmsTXPtocySHLp_Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=andrew@openedhand.com \
    --cc=anthony@codemonkey.ws \
    --cc=i.mitsyanko@gmail.com \
    --cc=michael@walle.cc \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.