From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gP7Lv-0005nn-Mu for qemu-devel@nongnu.org; Tue, 20 Nov 2018 09:50:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gP7Lu-0001QX-SY for qemu-devel@nongnu.org; Tue, 20 Nov 2018 09:50:11 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:43080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gP7Lu-0001QP-Oa for qemu-devel@nongnu.org; Tue, 20 Nov 2018 09:50:10 -0500 Received: by mail-oi1-x244.google.com with SMTP id u18so1665643oie.10 for ; Tue, 20 Nov 2018 06:50:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com> References: <20181119120820.29878-1-maozhongyi@cmss.chinamobile.com> <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com> From: Peter Maydell Date: Tue, 20 Nov 2018 14:49:49 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 20/22] xen_backend: Convert sysbus init function to realize function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mao Zhongyi Cc: QEMU Developers , Anthony PERARD , "open list:X86" , Stefano Stabellini , Zhang Shengju On 19 November 2018 at 12:08, Mao Zhongyi wrote: > Use DeviceClass rather than SysBusDeviceClass in > xen_sysdev_class_init(). > > Cc: sstabellini@kernel.org > Cc: anthony.perard@citrix.com > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Mao Zhongyi > Signed-off-by: Zhang Shengju > --- > hw/xen/xen_backend.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c > index 9a8e8771ec..73b0ed0169 100644 > --- a/hw/xen/xen_backend.c > +++ b/hw/xen/xen_backend.c > @@ -809,9 +809,8 @@ static const TypeInfo xensysbus_info = { > } > }; > > -static int xen_sysdev_init(SysBusDevice *dev) > +static void xen_sysdev_realize(DeviceState *dev, Error **errp) > { > - return 0; > } > > static Property xen_sysdev_properties[] = { > @@ -821,9 +820,8 @@ static Property xen_sysdev_properties[] = { > static void xen_sysdev_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); > > - k->init = xen_sysdev_init; > + dc->realize = xen_sysdev_realize; > dc->props = xen_sysdev_properties; > dc->bus_type = TYPE_XENSYSBUS; > } If the realize function doesn't do anything at all, can't we just omit it ? thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Maydell Subject: Re: [Qemu-devel] [PATCH 20/22] xen_backend: Convert sysbus init function to realize function Date: Tue, 20 Nov 2018 14:49:49 +0000 Message-ID: References: <20181119120820.29878-1-maozhongyi@cmss.chinamobile.com> <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gP7Lv-0007Dy-6B for xen-devel@lists.xenproject.org; Tue, 20 Nov 2018 14:50:11 +0000 Received: by mail-oi1-x241.google.com with SMTP id b141so1658564oii.12 for ; Tue, 20 Nov 2018 06:50:10 -0800 (PST) In-Reply-To: <20181119120820.29878-21-maozhongyi@cmss.chinamobile.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Mao Zhongyi Cc: Anthony PERARD , "open list:X86" , Stefano Stabellini , QEMU Developers , Zhang Shengju List-Id: xen-devel@lists.xenproject.org T24gMTkgTm92ZW1iZXIgMjAxOCBhdCAxMjowOCwgTWFvIFpob25neWkKPG1hb3pob25neWlAY21z cy5jaGluYW1vYmlsZS5jb20+IHdyb3RlOgo+IFVzZSBEZXZpY2VDbGFzcyByYXRoZXIgdGhhbiBT eXNCdXNEZXZpY2VDbGFzcyBpbgo+IHhlbl9zeXNkZXZfY2xhc3NfaW5pdCgpLgo+Cj4gQ2M6IHNz dGFiZWxsaW5pQGtlcm5lbC5vcmcKPiBDYzogYW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbQo+IENj OiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKPgo+IFNpZ25lZC1vZmYtYnk6IE1hbyBa aG9uZ3lpIDxtYW96aG9uZ3lpQGNtc3MuY2hpbmFtb2JpbGUuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IFpoYW5nIFNoZW5nanUgPHpoYW5nc2hlbmdqdUBjbXNzLmNoaW5hbW9iaWxlLmNvbT4KPiAtLS0K PiAgaHcveGVuL3hlbl9iYWNrZW5kLmMgfCA2ICsrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2h3L3hlbi94ZW5f YmFja2VuZC5jIGIvaHcveGVuL3hlbl9iYWNrZW5kLmMKPiBpbmRleCA5YThlODc3MWVjLi43M2Iw ZWQwMTY5IDEwMDY0NAo+IC0tLSBhL2h3L3hlbi94ZW5fYmFja2VuZC5jCj4gKysrIGIvaHcveGVu L3hlbl9iYWNrZW5kLmMKPiBAQCAtODA5LDkgKzgwOSw4IEBAIHN0YXRpYyBjb25zdCBUeXBlSW5m byB4ZW5zeXNidXNfaW5mbyA9IHsKPiAgICAgIH0KPiAgfTsKPgo+IC1zdGF0aWMgaW50IHhlbl9z eXNkZXZfaW5pdChTeXNCdXNEZXZpY2UgKmRldikKPiArc3RhdGljIHZvaWQgeGVuX3N5c2Rldl9y ZWFsaXplKERldmljZVN0YXRlICpkZXYsIEVycm9yICoqZXJycCkKPiAgewo+IC0gICAgcmV0dXJu IDA7Cj4gIH0KPgo+ICBzdGF0aWMgUHJvcGVydHkgeGVuX3N5c2Rldl9wcm9wZXJ0aWVzW10gPSB7 Cj4gQEAgLTgyMSw5ICs4MjAsOCBAQCBzdGF0aWMgUHJvcGVydHkgeGVuX3N5c2Rldl9wcm9wZXJ0 aWVzW10gPSB7Cj4gIHN0YXRpYyB2b2lkIHhlbl9zeXNkZXZfY2xhc3NfaW5pdChPYmplY3RDbGFz cyAqa2xhc3MsIHZvaWQgKmRhdGEpCj4gIHsKPiAgICAgIERldmljZUNsYXNzICpkYyA9IERFVklD RV9DTEFTUyhrbGFzcyk7Cj4gLSAgICBTeXNCdXNEZXZpY2VDbGFzcyAqayA9IFNZU19CVVNfREVW SUNFX0NMQVNTKGtsYXNzKTsKPgo+IC0gICAgay0+aW5pdCA9IHhlbl9zeXNkZXZfaW5pdDsKPiAr ICAgIGRjLT5yZWFsaXplID0geGVuX3N5c2Rldl9yZWFsaXplOwo+ICAgICAgZGMtPnByb3BzID0g eGVuX3N5c2Rldl9wcm9wZXJ0aWVzOwo+ICAgICAgZGMtPmJ1c190eXBlID0gVFlQRV9YRU5TWVNC VVM7Cj4gIH0KCklmIHRoZSByZWFsaXplIGZ1bmN0aW9uIGRvZXNuJ3QgZG8gYW55dGhpbmcgYXQg YWxsLCBjYW4ndAp3ZSBqdXN0IG9taXQgaXQgPwoKdGhhbmtzCi0tIFBNTQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==