From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bX9gq-0002OL-FD
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:15:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bX9gk-0008JB-NN
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:15:39 -0400
Received: from mail-ua0-x229.google.com ([2607:f8b0:400c:c08::229]:34437)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bX9gk-0008J6-Er
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:15:34 -0400
Received: by mail-ua0-x229.google.com with SMTP id k90so27557470uak.1
	for <qemu-devel@nongnu.org>; Tue, 09 Aug 2016 09:15:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1470758127-17769-3-git-send-email-alex.bennee@linaro.org>
References: <1470758127-17769-1-git-send-email-alex.bennee@linaro.org>
	<1470758127-17769-3-git-send-email-alex.bennee@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 9 Aug 2016 17:15:13 +0100
Message-ID: <CAFEAcA93t0uDx4ip3c6FuB9A3XufZ9+MLKO1eMki22XRJroM1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC for 2.8 2/3] configure: filter 64 bit
 machines on 32 bit builds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On 9 August 2016 at 16:55, Alex Benn=C3=A9e <alex.bennee@linaro.org> wrote:
> If the user doesn't specify any targets we build a default_target_list
> from the target .mak fragements. If we don't filter out the 64 bit
> targets when building on 32 bit machines we'll error out later on.
>
> Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
> ---
>  configure | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7b779c1..5499dbc 100755
> --- a/configure
> +++ b/configure
> @@ -1252,7 +1252,21 @@ if [ "$bsd_user" =3D "yes" ]; then
>  fi
>
>  for config in $mak_wilds; do
> -    default_target_list=3D"${default_target_list} $(basename "$config" .=
mak)"
> +
> +    target=3D$(basename "$config" .mak)
> +
> +    if test "$cpu_width" =3D "32"; then
> +        case $target in
> +            *64*|s390x-*)
> +                # skip 64 bit machines
> +                ;;
> +            *)
> +                default_target_list=3D"${default_target_list} ${target}"
> +                ;;
> +        esac
> +    else
> +        default_target_list=3D"${default_target_list} ${target}"
> +    fi
>  done

Ah, this is where the default target list gets updated.
You need to squash this into patch 1 or you break bisection
on 32-bit hosts.

thanks
-- PMM